-
Notifications
You must be signed in to change notification settings - Fork 1.9k
adding a dependency to the MlNetMklDeps package #594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Introducing the entry point for Ols, and enabling its test Adding documentation for Ols
@@ -11,6 +11,7 @@ | |||
<ProjectReference Include="..\Microsoft.ML.CpuMath\Microsoft.ML.CpuMath.csproj" /> | |||
<ProjectReference Include="..\Microsoft.ML.Data\Microsoft.ML.Data.csproj" /> | |||
<ProjectReference Include="..\Microsoft.ML\Microsoft.ML.csproj" /> | |||
<PackageReference Include="MlNetMklDeps" Version="$(MlNetMklDepsPackageVersion)" /> | |||
</ItemGroup> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmmm. I wonder if OLS really belongs in standard learners if it has native dependencies. Well, we'll possibly resolve that later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for handling this sticky situation @sfilipi .
Just wondering @sfilipi , what is the relationship of this with #578 ? I assume this PR supersedes it, and you found some other way to publish the nuget? Or does it depend on #578, and we will be consuming a nuget that is built out of the same repo? (Though presumably via some other process.) #Pending |
Thanks @TomFinley for reviewing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for doing this.!
@@ -11,6 +11,7 @@ | |||
<ProjectReference Include="..\Microsoft.ML.CpuMath\Microsoft.ML.CpuMath.csproj" /> | |||
<ProjectReference Include="..\Microsoft.ML.Data\Microsoft.ML.Data.csproj" /> | |||
<ProjectReference Include="..\Microsoft.ML\Microsoft.ML.csproj" /> | |||
<PackageReference Include="MlNetMklDeps" Version="$(MlNetMklDepsPackageVersion)" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't going to work because the Microsoft.ML
package doesn't reference the MlNetMklDeps
package (and in my opinion, it should never reference it).
We will need to split OLS (and any other functionaltiy that depends on MKL) out into a separate NuGet package.
In general, if a component takes a dependency on "non-standard" or "large" external dependencies, we can't ship that component in our "Main" nuget package.
Introducing the entry point for Ols, and enabling its test Adding documentation for Ols
Introducing the entry point for Ols, and enabling its test
Adding documentation for Ols
Resolves #497