Skip to content

Updated version number of MlNetMklDeps package to 0.0.0.6 #860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 12, 2018

Conversation

artidoro
Copy link
Contributor

@artidoro artidoro commented Sep 7, 2018

Fixes #859.

I updated the version number of the package MlNetMklDeps in build/Dependencies.props.

Although ML.NET does not officially support x86 at this moment, the new MlNetMklDeps nuget package contains the x86 binaries.

@artidoro artidoro requested a review from sfilipi September 7, 2018 22:25
@sfilipi
Copy link
Member

sfilipi commented Sep 7, 2018

Change looks good to me. @tannergooding did you have a chance to test the package?

@tannergooding
Copy link
Member

I'll be able to finish validating that everything works correctly before standup on Monday

@tannergooding
Copy link
Member

The native builds all succeed. I'm working on a few small fixes to the managed build so it can consume the x86 native bits as well.

@TomFinley
Copy link
Contributor

TomFinley commented Sep 12, 2018

Hello @sfilipi and @tannergooding and @artidoro ! I would feel more comfortable if one of you who spent some effort reviewing the PR (to say nothing of understanding what it is for) would also be the one to actually merge it.

@sfilipi
Copy link
Member

sfilipi commented Sep 12, 2018

This PR enabled ML.NEt to reference the MLNetMKLDeps NuGet package version 0.0.0.6.
This NuGet contains, in addition to the binaries present in 0.0.0.5, also the binaries for windows x86. @tannergooding needs to build ml.net on x86.

@sfilipi sfilipi merged commit 2e1fa4e into dotnet:master Sep 12, 2018
@artidoro artidoro deleted the mklv0.0.0.6 branch January 5, 2019 00:02
@ghost ghost locked as resolved and limited conversation to collaborators Mar 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants