Skip to content

Change "Documentation" folder to "docs" #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 17, 2018
Merged

Conversation

asthana86
Copy link
Contributor

In order to add consistency would like to change "Documentation" to "Docs" and fix all links in .MD files and .sln.

asthana86 added 3 commits May 8, 2018 23:54
Fixing as a result all broken links for MDs in the following files:
Readme.md:
  "The current release is 0.1. Check out the [release notes](docs/release-notes/0.1/
  release-0.1.md)."
 "To build ML.NET from source please visit our [developers guide](docs/project-docs/developer-guide.md)."
Fixing as a result all broken links for MDs in the following files:
Readme.md:
  "The current release is 0.1. Check out the [release notes](docs/release-notes/0.1/
  release-0.1.md)."
 "To build ML.NET from source please visit our [developers guide](docs/project-docs/developer-guide.md)."
@asthana86 asthana86 requested review from danmoseley and glebuk May 9, 2018 07:15
@dnfclas
Copy link

dnfclas commented May 9, 2018

CLA assistant check
All CLA requirements met.

Copy link
Member

@eerhardt eerhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@asthana86 - I don't see the actual folder being renamed - just the links being updated to a non-existent folder. Did you intend to rename the folder as well?

@justinormont
Copy link
Contributor

As per the contribution guide, can you file an issue? This will let folks have time and a place to discuss the change.

@justinormont justinormont self-requested a review May 13, 2018 17:45
@asthana86
Copy link
Contributor Author

#143 created an issue for this.

@@ -13,7 +13,7 @@ dotnet add package Microsoft.ML

From package manager:
```
Install-Package Microsoft.ML
Install-Package Microsoft.ML
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we adding these spaces here?

Copy link
Contributor

@glebuk glebuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@shauheen shauheen merged commit 616e75f into dotnet:master May 17, 2018
TomFinley added a commit to TomFinley/machinelearning that referenced this pull request May 17, 2018
TomFinley added a commit to TomFinley/machinelearning that referenced this pull request May 22, 2018
eerhardt pushed a commit to eerhardt/machinelearning that referenced this pull request Jul 27, 2018
* Changing name "Documentation" to "docs" for consistency in the repo.
Fixes dotnet#143
@ghost ghost locked as resolved and limited conversation to collaborators Mar 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants