WordEmbedding Tests added plus added dimension check for the first row #880
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Benchmark results for this test Toolchain=netcoreapp2.1 MaxIterationCount=20 WarmupCount=1
BigramAndTrigramBenchmark.CV_Multiclass_WikiDetox_WordEmbeddings_OVAAveragedPerceptron:
Mean = 291.0139 s, StdErr = 0.3224 s (0.11%); N = 15, StdDev = 1.2487 s
Min = 288.9763 s, Q1 = 289.8307 s, Median = 291.3262 s, Q3 = 292.1041 s, Max = 292.6711 s
IQR = 2.2734 s, LowerFence = 286.4205 s, UpperFence = 295.5143 s
ConfidenceInterval = [289.6789 s; 292.3489 s] (CI 99.9%), Margin = 1.3350 s (0.46% of Mean)
Skewness = -0.19, Kurtosis = 1.39, MValue = 2
-------------------- Histogram --------------------
[288.533 s ; 293.114 s) | @@@@@@@@@@@@@@@
---------------------------------------------------
BigramAndTrigramBenchmark.CV_Multiclass_WikiDetox_WordEmbeddings_SDCAMC:
Mean = 191.1037 s, StdErr = 0.2887 s (0.15%); N = 13, StdDev = 1.0408 s
Min = 190.0461 s, Q1 = 190.2511 s, Median = 190.7204 s, Q3 = 192.2263 s, Max = 193.1013 s
IQR = 1.9752 s, LowerFence = 187.2882 s, UpperFence = 195.1891 s
ConfidenceInterval = [189.8574 s; 192.3501 s] (CI 99.9%), Margin = 1.2464 s (0.65% of Mean)
Skewness = 0.66, Kurtosis = 1.74, MValue = 2
-------------------- Histogram --------------------
[189.659 s ; 193.489 s) | @@@@@@@@@@@@@
---------------------------------------------------
|
|
@sfilipi is added to the review. #Closed |
sfilipi
reviewed
Sep 12, 2018
| public void CV_Multiclass_WikiDetox_WordEmbeddings_SDCAMC() | ||
| { | ||
| string cmd = @"CV tr=SDCAMC k=5 loader=TextLoader{quote=- sparse=- col=Label:R4:0 col=rev_id:TX:1 col=comment:TX:2 col=logged_in:BL:4 col=ns:TX:5 col=sample:TX:6 col=split:TX:7 col=year:R4:3 header=+} data=" + _dataPath_Wiki + " xf=Convert{col=logged_in type=R4} xf=CategoricalTransform{col=ns} xf=TextTransform{col=FeaturesText:comment tokens=+ wordExtractor={} charExtractor={}} xf=WordEmbeddingsTransform{col=FeaturesWordEmbedding:FeaturesText_TransformedText model=FastTextWikipedia300D} xf=Concat{col=Features:FeaturesWordEmbedding,logged_in,ns}"; | ||
| using (var tlc = new TlcEnvironment(verbose: false, sensitivity: MessageSensitivity.None, outWriter: EmptyWriter.Instance)) |
There was a problem hiding this comment.
indent those, maybe, for readability
There was a problem hiding this comment.
indent the cmd or tlc environment ?
There was a problem hiding this comment.
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #873
Related PR #820
please review it after 55fb378
cc @danmosemsft @sfilipi @eerhardt @Ivanidzo4ka @justinormont