-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Converted listed text transforms into transformers/estimators. #953
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
73c2aa8
Transform wrappers and a reference implementation for tokenizers
d145d07
Added pigsty extensions
6bd2bf4
Merge remote-tracking branch 'upstream/master' into feature/transform…
e8ef7ef
Added pigsty test
1350587
Fixed most important PR comments
450efda
PR comments
db261f8
Merge branch 'feature/transform-wrapper' of github.com:Zruty0/machine…
1653e1c
Merge remote-tracking branch 'pete_fork/feature/transform-wrapper' in…
zeahmed 4a93c72
Converted all text transforms into transformers/estimators.
zeahmed 6b28ca6
Resolved merge conflicts.
zeahmed ee835d1
Addressed reviewers's comments.
zeahmed 4659b80
Addressed reviewers' comments.
zeahmed da08376
Resolved merge conflicts.
zeahmed 9688edd
Addressed a few formating comments.
zeahmed File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
479 changes: 479 additions & 0 deletions
479
src/Microsoft.ML.Transforms/Text/TextStaticExtensions.cs
Large diffs are not rendered by default.
Oops, something went wrong.
613 changes: 613 additions & 0 deletions
613
src/Microsoft.ML.Transforms/Text/WrappedTextTransformers.cs
Large diffs are not rendered by default.
Oops, something went wrong.
Large diffs are not rendered by default.
Oops, something went wrong.
Large diffs are not rendered by default.
Oops, something went wrong.
11 changes: 11 additions & 0 deletions
11
test/BaselineOutput/SingleDebug/Text/words_without_stopwords.tsv
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
#@ TextLoader{ | ||
#@ header+ | ||
#@ sep=tab | ||
#@ col=text:TX:0 | ||
#@ col=words_without_stopwords:TX:1-** | ||
#@ } | ||
text | ||
==rude== dude, you are rude upload that carl picture back, or else. ==rude== dude, you rude upload carl picture back, else. | ||
== ok! == im going to vandalize wild ones wiki then!!! == ok! == im going vandalize wild ones wiki then!!! | ||
stop trolling, zapatancas, calling me a liar merely demonstartes that you arer zapatancas. you may choose to chase every legitimate editor from this site and ignore me but i am an editor with a record that isnt 99% trolling and therefore my wishes are not to be completely ignored by a sockpuppet like yourself. the consensus is overwhelmingly against you and your trollin g lover zapatancas, stop trolling, zapatancas, calling liar merely demonstartes you arer zapatancas. you choose chase legitimate editor site ignore i editor record isnt 99% trolling wishes completely ignored sockpuppet like yourself. consensus overwhelmingly you your trollin g lover zapatancas, | ||
==you're cool== you seem like a really cool guy... *bursts out laughing at sarcasm*. ==you're cool== you like really cool guy... *bursts laughing sarcasm*. |
Large diffs are not rendered by default.
Oops, something went wrong.
Large diffs are not rendered by default.
Oops, something went wrong.
11 changes: 11 additions & 0 deletions
11
test/BaselineOutput/SingleRelease/Text/words_without_stopwords.tsv
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
#@ TextLoader{ | ||
#@ header+ | ||
#@ sep=tab | ||
#@ col=text:TX:0 | ||
#@ col=words_without_stopwords:TX:1-** | ||
#@ } | ||
text | ||
==rude== dude, you are rude upload that carl picture back, or else. ==rude== dude, you rude upload carl picture back, else. | ||
== ok! == im going to vandalize wild ones wiki then!!! == ok! == im going vandalize wild ones wiki then!!! | ||
stop trolling, zapatancas, calling me a liar merely demonstartes that you arer zapatancas. you may choose to chase every legitimate editor from this site and ignore me but i am an editor with a record that isnt 99% trolling and therefore my wishes are not to be completely ignored by a sockpuppet like yourself. the consensus is overwhelmingly against you and your trollin g lover zapatancas, stop trolling, zapatancas, calling liar merely demonstartes you arer zapatancas. you choose chase legitimate editor site ignore i editor record isnt 99% trolling wishes completely ignored sockpuppet like yourself. consensus overwhelmingly you your trollin g lover zapatancas, | ||
==you're cool== you seem like a really cool guy... *bursts out laughing at sarcasm*. ==you're cool== you like really cool guy... *bursts laughing sarcasm*. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is invalid data the same as the valid one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Its not valid. Here text is tried to be loaded as float.
In reply to: 219582043 [](ancestors = 219582043)