Skip to content

enabling scanning the constructors with non-public visibility, and re… #963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 20, 2018

Conversation

sfilipi
Copy link
Member

@sfilipi sfilipi commented Sep 20, 2018

enabling scanning the constructors with non-public visibility, and reducing the visibility of some of them to avoid confusing the users.

…ducing the visibility of some of them to avoid confusing the users.
@sfilipi sfilipi self-assigned this Sep 20, 2018
@sfilipi sfilipi added the API Issues pertaining the friendly API label Sep 20, 2018
Copy link
Contributor

@Zruty0 Zruty0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@sfilipi sfilipi requested a review from TomFinley September 20, 2018 17:51
Swapping ctor visibility in SDCA, and fixing the test to reference the public ctor.
@sfilipi
Copy link
Member Author

sfilipi commented Sep 20, 2018

dotnet-bot build this

@sfilipi sfilipi closed this Sep 20, 2018
@sfilipi
Copy link
Member Author

sfilipi commented Sep 20, 2018

Close-reopen to trigger re-build

@sfilipi sfilipi reopened this Sep 20, 2018
Copy link
Contributor

@TomFinley TomFinley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @sfilipi

@TomFinley TomFinley merged commit 6812cb5 into dotnet:master Sep 20, 2018
@sfilipi sfilipi deleted the reduceCtorVisib branch October 20, 2018 03:12
@ghost ghost locked as resolved and limited conversation to collaborators Mar 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
API Issues pertaining the friendly API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants