Skip to content

PcaTrainer as estimator #996

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Sep 25, 2018
Merged

PcaTrainer as estimator #996

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
662d19c
adding test +fit and finish
sfilipi Sep 21, 2018
5220393
merge from master
sfilipi Sep 22, 2018
c1d54f7
dehydrate
sfilipi Sep 23, 2018
9d5783d
tidying the PredictionTransformer class.
sfilipi Sep 24, 2018
431cfae
adressing review comments.
sfilipi Sep 25, 2018
6708f7f
Merge branch 'master' into PCAEstimator
sfilipi Sep 25, 2018
83b1daf
Merge branch 'PCAEstimator' of https://github.com/sfilipi/machinelear…
sfilipi Sep 25, 2018
2974c38
Merge remote-tracking branch 'upstream/master' into PCAEstimator
sfilipi Sep 25, 2018
43f5775
merging from master
sfilipi Sep 25, 2018
eac7be4
Revert "merging from master"
sfilipi Sep 25, 2018
f1a1213
post master merge fix.
sfilipi Sep 25, 2018
65c1ee3
Call Done() when test is done.
sfilipi Sep 25, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions src/Microsoft.ML.Data/Scorers/BinaryClassifierScorer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -298,8 +298,6 @@ private static ColumnType GetPredColType(ColumnType scoreType, ISchemaBoundRowMa
}

private static bool OutputTypeMatches(ColumnType scoreType)
{
return scoreType == NumberType.Float;
}
=> scoreType == NumberType.Float;
}
Copy link
Contributor

@TomFinley TomFinley Sep 25, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bit of a nit, but while you're at it, maybe indent properly. #Closed

}
Loading