Skip to content

Conversation

rmarinho
Copy link
Member

@rmarinho rmarinho commented Jul 2, 2021

Description of Change

Fix issue with siging assemblies with wrong name

Additions made

  • Adds

PR Checklist

  • Targets the correct branch
  • Tests are passing (or failures are unrelated)
  • Targets a single property for a single control (or intertwined few properties)
  • Adds the property to the appropriate interface
  • Avoids any changes not essential to the handler property
  • Adds the mapping to the PropertyMapper in the handler
  • Adds the mapping method to the Android, iOS, and Standard aspects of the handler
  • Implements the actual property updates (usually in extension methods in the Platform section of Core)
  • Tags ported renderer methods with [PortHandler]
  • Adds an example of the property to the sample project (MainPage)
  • Adds the property to the stub class
  • Implements basic property tests in DeviceTests

Does this PR touch anything that might affect accessibility?

  • Does this PR introduce a new control? (If yes, add an example using SemanticProperties to the SemanticsPage)
  • APIs that modify focusability?
  • APIs that modify any text property on a control?
  • Does this PR modify view nesting or view arrangement in anyway?
  • Is there the smallest possibility that your PR will change accessibility?
  • I'm not sure, please help me

If any of the above checkboxes apply to your PR, then the PR will need to provide testing to demonstrate that accessibility still works.

@rmarinho rmarinho merged commit 71a6418 into main Jul 2, 2021
@rmarinho rmarinho deleted the fix-Benchmarks-net6 branch July 2, 2021 10:06
Csaba8472 added a commit to Csaba8472/maui that referenced this pull request Sep 6, 2021
* upstream/main: (270 commits)
  Automated dotnet-format update (dotnet#1533)
  Add tests for default colors (dotnet#1532)
  Don't extract native defaults, meaning users can no longer reset a color back to a platform theme (dotnet#1485)
  Avoid show the virtual keyboard in the Android TimePicker (dotnet#1428)
  Implement VerticalTextAlignment in WinUI Label (dotnet#1479)
  Changes in the Gallery: include custom fonts, reorganize some pages, etc. (dotnet#1526)
  Don't pack and force a signing failure (dotnet#1527)
  [main] Update dependencies from xamarin/xamarin-android (dotnet#1443)
  Implements EntryHandler IsPassword in WinUI (dotnet#802)
  Automated dotnet-format update (dotnet#1523)
  [Build] Fix net6 Microsoft.Maui.Handlers.Benchmarks assembly (dotnet#1525)
  Update WinUI to 0.8 stable (dotnet#1522)
  Implement the basic WindowHandler (dotnet#1468)
  Automated dotnet-format update (dotnet#1510)
  Implement Alerts (Alert, Prompt and ActionSheet) (dotnet#1328)
  Avoid create a drawable to set the Background if is not necessary (dotnet#1504)
  Android Gestures (dotnet#1489)
  Revert to using Navigation Page Shims (dotnet#1495)
  Allow to navigate to the same item after navigate back (dotnet#1503)
  Automated dotnet-format update (dotnet#1499)
  ...
@github-actions github-actions bot locked and limited conversation to collaborators Dec 25, 2023
@samhouts samhouts added the fixed-in-6.0.100-preview.6 Look for this fix in 6.0.100-preview.6! label Aug 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

fixed-in-6.0.100-preview.6 Look for this fix in 6.0.100-preview.6!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants