Skip to content

Conversation

JanKrivanek
Copy link
Member

Fixes #11051

Context

For various hangs detection we need worker processes dumps. Let's unblock VS perf team in enabling automatic collection of worker processes dumps.

Testing

No tests provided.
This is best effort, point in time functionality, that should be used so

FYI @davkean

@JanKrivanek JanKrivanek enabled auto-merge (squash) December 13, 2024 18:52
Copy link
Member

@maridematte maridematte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know we also have some issues that have the error "Node # has exited unexpectedly", could a bit more information on the nodes help with that one too?

@JanKrivanek
Copy link
Member Author

I know we also have some issues that have the error "Node # has exited unexpectedly", could a bit more information on the nodes help with that one too?

Tho goal of this PR is to help collect more relevant data with perfWatson on VS hangs - as important context might be in running out-of-proc MSBuild nodes, for which we are missing dumps.
If the node process crashes - then dump is already automatically collected.
So I feel there is no other information we can add here for the crashing nodes. But kick me harder if I'm missing something specific you have on mind :-)

@JanKrivanek JanKrivanek merged commit c03b15e into main Jan 3, 2025
10 checks passed
@JanKrivanek JanKrivanek deleted the proto/get-bldmgr-processes branch January 3, 2025 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Expose worker node PIDs via BuildManager API

5 participants