Skip to content

Conversation

JanProvaznik
Copy link
Member

Context

we should be inserting 17.14 to 17.14 & the schedule should be set for main normal insertion not the experimental one

Changes Made

Pseudo-reverts #11558

Notes

should be merged forward to main

@JanProvaznik JanProvaznik requested a review from a team as a code owner May 26, 2025 15:17
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Updates the insertion branch and scheduling logic for VS insertions and bumps the tooling version.

  • Bumps the VersionPrefix to 17.14.11 in eng/Versions.props.
  • Enables and configures the daily main schedule in vs-insertion.yml and updates the AutoInsertTargetBranch for vs17.14.
  • Removes the now-unused experimental schedule block from vs-insertion-experimental.yml.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
eng/Versions.props Bumped VersionPrefix from 17.14.10 to 17.14.11
azure-pipelines/vs-insertion.yml Enabled daily main schedule; changed AutoInsertTargetBranch for vs17.14
azure-pipelines/vs-insertion-experimental.yml Removed the experimental scheduling block
Comments suppressed due to low confidence (1)

azure-pipelines/vs-insertion-experimental.yml:4

  • [nitpick] The commented experimental schedule block is no longer needed; consider removing these lines to reduce clutter.
-# Since our release branch is the one flowing into main

@JanProvaznik
Copy link
Member Author

Actually it was fixed in main but not in 17.14 :( so that's the only meaningful change (the rest is just so that the code is consistent between branches)

@JanProvaznik JanProvaznik merged commit 43442d7 into dotnet:vs17.14 May 27, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants