Skip to content

Conversation

AR-May
Copy link
Member

@AR-May AR-May commented Nov 14, 2022

Context

Opt-prof v2 pipeline is failing for "vs*" branches on the machine deployment stage, during the VS installation.
This PR should fix the issue.

Testing

Experimental runs of Opt-Prof v2 pipeline for vs17.2 and main branches.

optOptimizationInputsDropName: $(OptimizationInputsDropName)
testLabPoolName: VS-Platform # The test lab pool to run your tests in
testMachineImageName: Windows-10-Enterprise-20H2
visualStudioSigning: Test
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this go into 17.0/16.11 and get merged forward?

@AR-May
Copy link
Member Author

AR-May commented Nov 23, 2022

I added (#8189) this yml to 16.11, including this fix, we will let it flow up.

@AR-May AR-May closed this Nov 23, 2022
@rainersigwald rainersigwald reopened this Dec 5, 2022
Copy link
Member

@rainersigwald rainersigwald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Flow is slow, I agree we can get this in main ASAP.

@rainersigwald rainersigwald enabled auto-merge (squash) December 5, 2022 16:07
@rainersigwald rainersigwald merged commit b26c3d1 into dotnet:main Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants