Skip to content

Conversation

Forgind
Copy link
Contributor

@Forgind Forgind commented Jan 25, 2023

(Copied from #8351)

Fixes AB#1678521

Context
#8049 broke the temp filtering logic by using the MSBuild-specific temp path instead of the true base temp path. This manifests as an overbuild of some C++ projects.

Changes Made
Reverted the change. Enabled relevant unit tests.

Testing
Existing unit tests and a C++ end-to-end repro.

Notes
The rest of FileTracker tests cannot be enabled without significant work (related to #649).

@JanKrivanek
Copy link
Member

Btw. would a cherrypick be possible here? The branches doesn't seem to be much diverged: https://github.com/dotnet/msbuild/compare/main...vs17.0?expand=1

If we'd do a similar thing more often then once in a blue moon, than we can introduce backport GHA:
https://github.com/dotnet/arcade/blob/main/.github/workflows/backport-base.yml

@Forgind
Copy link
Contributor Author

Forgind commented Jan 30, 2023

Btw. would a cherrypick be possible here? The branches doesn't seem to be much diverged: https://github.com/dotnet/msbuild/compare/main...vs17.0?expand=1

If we'd do a similar thing more often then once in a blue moon, than we can introduce backport GHA: https://github.com/dotnet/arcade/blob/main/.github/workflows/backport-base.yml

I initially tried to cherry-pick, but there was apparently a conflict on the tests, so it ended up as a new commit. The 17.5 one went in more cleanly.

@JanKrivanek
Copy link
Member

JanKrivanek commented Jan 30, 2023

Btw. I added a proposal for minimalistic backport action - for non-diverging branches we can then port simply via comment on original PR: #8368

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants