Catch the illegal argument exception in Net Framework! #8839
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JanKrivanek
approved these changes
Jun 5, 2023
src/Build.UnitTests/Evaluation/ImportFromMSBuildExtensionsPath_Tests.cs
Outdated
Show resolved
Hide resolved
YuliiaKovalova
approved these changes
Sep 13, 2023
bulatgrzegorz
pushed a commit
to bulatgrzegorz/selective-condition-evaluator
that referenced
this pull request
Oct 16, 2023
Fixes dotnet#8762 Context Catch the exceptions when extensionsPathPropValue is null or importExpandedWithDefaultPath is empty. In NET Framework, Path.* function also throws exceptions if the path contains invalid characters Changes Made Catch the exception. Testing FallbackImportWithInvalidProjectValue Notes
MichalPavlik
pushed a commit
that referenced
this pull request
Oct 17, 2023
Fixes #8762 Context Catch the exceptions when extensionsPathPropValue is null or importExpandedWithDefaultPath is empty. In NET Framework, Path.* function also throws exceptions if the path contains invalid characters Changes Made Catch the exception. Testing FallbackImportWithInvalidProjectValue Notes
This was referenced Jul 29, 2025
Closed
Closed
This was referenced Oct 15, 2025
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8762
Context
Catch the exceptions when extensionsPathPropValue is null or importExpandedWithDefaultPath is empty.
In NET Framework, Path.* function also throws exceptions if the path contains invalid characters
Changes Made
Catch the exception.
Testing
FallbackImportWithInvalidProjectValue
Notes