remove #if NEVER in hashset #8986
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ladipro
approved these changes
Jul 3, 2023
There was a problem hiding this comment.
nit: The Originals directory is now empty, so maybe this can be removed as well?
msbuild/src/Build/Microsoft.Build.csproj
Lines 803 to 805 in 39e20dc
|
Is it still necessary to keep modified copies of BCL containers in this repo? Specifically for |
Not that I'm aware of. Note that it's a hybrid of the two- a dictionary with the storage of a HashSet, because the key is stored on the value |
fixed |
YuliiaKovalova
approved these changes
Jul 4, 2023
This was referenced Jul 29, 2025
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a modified copy of Hashset and someone circa 2008 figured it would be helpful to have the unused bits commented out (and indented) so as to easily diff the two. That turned out to be unnecessary.