Initial version of Analyzers specs #9853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

JanKrivanek merged 25 commits into dotnet:main from JanKrivanek:doc/analyzers

Apr 11, 2024

Member

JanKrivanek commented Mar 12, 2024 •

edited

Loading

Fixes #9895

Context

Initial draft of specs (external and internal design) fpr Analyzers (AKA BuildCheck) feature.
Should as well serve as supportive materials for reviewing #9735


          Initial draft of specs

968c003

JanKrivanek mentioned this pull request

Analyzers prototype proposal #9735

Merged

JanKrivanek added 3 commits

March 13, 2024 15:00


          Clarify

b523fe9


          Clarify configuration section

aeb92c6


          Improve wording

b2376cf

ladipro reviewed

View reviewed changes

documentation/specs/proposed/BuildCheck.md Outdated Show resolved Hide resolved

documentation/specs/proposed/BuildCheck.md Outdated Show resolved Hide resolved

documentation/specs/proposed/BuildCheck.md Show resolved Hide resolved

documentation/specs/proposed/BuildCheck.md Show resolved Hide resolved

baronfel reviewed

View reviewed changes

documentation/specs/proposed/BuildCheck.md Outdated Show resolved Hide resolved

documentation/specs/proposed/BuildCheck.md Outdated Show resolved Hide resolved

documentation/specs/proposed/BuildCheck.md Show resolved Hide resolved

documentation/specs/proposed/BuildCheck.md Outdated Show resolved Hide resolved

rainersigwald reviewed

View reviewed changes

Member

rainersigwald left a comment

First round comments, BuildCheck.md only

documentation/specs/proposed/BuildCheck.md Outdated Show resolved Hide resolved

documentation/specs/proposed/BuildCheck.md Outdated Show resolved Hide resolved

documentation/specs/proposed/BuildCheck.md Outdated Show resolved Hide resolved

documentation/specs/proposed/BuildCheck.md Outdated Show resolved Hide resolved

documentation/specs/proposed/BuildCheck.md Show resolved Hide resolved

documentation/specs/proposed/BuildCheck.md Outdated Show resolved Hide resolved

documentation/specs/proposed/BuildCheck.md Outdated Show resolved Hide resolved

documentation/specs/proposed/BuildCheck.md Outdated Show resolved Hide resolved

documentation/specs/proposed/BuildCheck.md Outdated Show resolved Hide resolved

documentation/specs/proposed/BuildCheck.md Show resolved Hide resolved

drewnoakes reviewed

View reviewed changes

documentation/specs/proposed/BuildCheck.md Outdated Show resolved Hide resolved

JanKrivanek and others added 2 commits

March 15, 2024 20:32


          Apply suggestions from code review

c38e806

Co-authored-by: Rainer Sigwald <[email protected]>
Co-authored-by: Chet Husk <[email protected]>


          Rework based on PR feedback

fbccee4

JanKrivanek requested review from baronfel, drewnoakes, ladipro and rainersigwald

March 15, 2024 21:28

rainersigwald reviewed

View reviewed changes

Member

rainersigwald left a comment

Architecture doc comments.

documentation/specs/proposed/BuildCheck-Architecture.md Outdated Show resolved Hide resolved

documentation/specs/proposed/BuildCheck-Architecture.md Outdated Show resolved Hide resolved

documentation/specs/proposed/BuildCheck.md Show resolved Hide resolved

documentation/specs/proposed/BuildCheck-Architecture.md Show resolved Hide resolved

documentation/specs/proposed/BuildCheck-Architecture.md Outdated Show resolved Hide resolved

documentation/specs/proposed/BuildCheck-Architecture.md Outdated Show resolved Hide resolved

documentation/specs/proposed/BuildCheck-Architecture.md Show resolved Hide resolved

documentation/specs/proposed/BuildCheck-Architecture.md Outdated Show resolved Hide resolved

documentation/specs/proposed/BuildCheck-Architecture.md Outdated Show resolved Hide resolved

documentation/specs/proposed/BuildCheck-Architecture.md Outdated Show resolved Hide resolved

rainersigwald reviewed

View reviewed changes

Member

rainersigwald left a comment

Architecture doc comments.

documentation/specs/proposed/BuildCheck.md Outdated Show resolved Hide resolved

documentation/specs/proposed/BuildCheck.md Outdated Show resolved Hide resolved

documentation/specs/proposed/BuildCheck-Architecture.md Outdated Show resolved Hide resolved

JanKrivanek changed the title ~~Initial draft of Analyzers specs~~ Initial version of Analyzers specs

JanKrivanek marked this pull request as ready for review

March 18, 2024 16:02

JanKrivanek and others added 3 commits

March 18, 2024 18:17


          PR review meeting feedback

ff567bd


          Apply suggestions from code review

d041ff8

Co-authored-by: Rainer Sigwald <[email protected]>


          Update based on PR feedback

08b3680

JanKrivanek requested a review from rainersigwald

March 18, 2024 18:03

rainersigwald reviewed

View reviewed changes

documentation/specs/proposed/BuildCheck-Architecture.md Outdated Show resolved Hide resolved

documentation/specs/proposed/BuildCheck-Architecture.md Outdated Show resolved Hide resolved

documentation/specs/proposed/BuildCheck-Architecture.md Outdated Show resolved Hide resolved

documentation/specs/proposed/BuildCheck-Architecture.md Show resolved Hide resolved

documentation/specs/proposed/BuildCheck-Architecture.md Outdated Show resolved Hide resolved

documentation/specs/proposed/BuildCheck.md Outdated Show resolved Hide resolved

documentation/specs/proposed/BuildCheck.md Outdated Show resolved Hide resolved

documentation/specs/proposed/BuildCheck.md Show resolved Hide resolved

documentation/specs/proposed/BuildCheck.md Outdated Show resolved Hide resolved

documentation/specs/proposed/BuildCheck.md Outdated Show resolved Hide resolved

drewnoakes reviewed

View reviewed changes

documentation/specs/proposed/BuildCheck-Architecture.md Show resolved Hide resolved

JanKrivanek and others added 4 commits

March 19, 2024 14:28


          Apply suggestions from code review

25ae871

Co-authored-by: Rainer Sigwald <[email protected]>


          Reflecting PR comments

7465f2d


          Add planned inbox checks

e4154d1


          Sample code formatting

d5b6357

JanKrivanek requested a review from rainersigwald

March 25, 2024 09:14

This was referenced Aug 17, 2025

Bump Microsoft.Build.Framework and Microsoft.Build.Utilities.Core wangyum/avro#344

Open

Bump Microsoft.Build.Framework from 17.8.3 to 17.14.8 wangyum/avro#358

Open

Bump Microsoft.Build.Tasks.Core from 17.11.31 to 17.14.8 dendrodocs/dotnet-client-lib#18

Open

Bump Microsoft.Build.Tasks.Core and Microsoft.Build.Utilities.Core devlooped/json#106

Open

Bump Microsoft.Build.Tasks.Core to 17.14.8 GeertvanHorrik/Fody#158

Closed

Bump Microsoft.Build.Framework and Microsoft.Build.Utilities.Core dotTrench/dotnet-proj-diff#43

Open

Bump Microsoft.Build.Framework to 17.14.8 dotTrench/dotnet-proj-diff#44

Closed

[Vulnerability Update]: Bump Microsoft.Build.Tasks.Core from 17.3.2 to 17.14.8 bouchraRekhadda/dependabot-sample#5

Closed

Bump Microsoft.Build.Tasks.Core to 17.14.8 GeertvanHorrik/Fody#159

Closed

Bump Microsoft.Build.Tasks.Core to 17.14.8 GeertvanHorrik/Fody#160

Closed

Bump Microsoft.Build.Tasks.Core to 17.14.8 GeertvanHorrik/Fody#161

Closed

Bump Microsoft.Build.Framework from 16.5.0 to 17.14.8 sundews/Sundew.Xaml.Optimizer.BuildTask#1

Closed

Bump Microsoft.Build.Framework and Microsoft.Build.Utilities.Core sundews/Sundew.Xaml.Optimizer.BuildTask#2

Closed

This was referenced Aug 25, 2025

Bump Microsoft.Build.Framework from 16.5.0 to 17.14.8 sundews/Sundew.Xaml.Optimizer.BuildTask#3

Closed

Bump Microsoft.Build.Tasks.Core to 17.14.8 GeertvanHorrik/Fody#162

Closed

Bump Microsoft.Build.Framework to 17.14.8 dotTrench/dotnet-proj-diff#55

Open

Bump Microsoft.Build.Tasks.Core to 17.14.8 GeertvanHorrik/Fody#163

Closed

Bump Microsoft.Build.Tasks.Core to 17.14.8 GeertvanHorrik/Fody#164

Closed

Bump Microsoft.Build.Framework from 17.11.4 to 17.14.8 microsoft/sbom-tool#1167

Closed

Bump Microsoft.Build.Utilities.Core from 17.11.4 to 17.14.8 microsoft/sbom-tool#1168

Closed

Bump Microsoft.Build.Framework from 17.11.4 to 17.14.8 microsoft/sbom-tool#1190

Closed

dependabot bot mentioned this pull request

Bump Microsoft.Build.Tasks.Core from 17.10.4 to 17.14.8 GeertvanHorrik/Fody#165

Closed

dependabot bot mentioned this pull request

Bump Microsoft.Build.Tasks.Core from 17.10.4 to 17.14.8 GeertvanHorrik/Fody#166

Merged

This was referenced Oct 15, 2025

Bump Microsoft.Build from 15.9.20 to 17.11.48 rajkumar-rangaraj/opentelemetry-dotnet-instrumentation#1085

Open

Bump Microsoft.Build.Utilities.Core from 15.9.20 to 17.14.28 rajkumar-rangaraj/opentelemetry-dotnet-instrumentation#1086

Open

Bump Microsoft.Build.Framework from 17.11.4 to 17.14.28 microsoft/sbom-tool#1264

Closed

Bump Microsoft.Build.Utilities.Core from 17.11.4 to 17.14.28 microsoft/sbom-tool#1265

Open

Bump Microsoft.Build.Framework from 16.5.0 to 17.14.28 sundews/Sundew.Xaml.Optimizer.BuildTask#6

Closed

Bump Microsoft.Build.Framework and Microsoft.Build.Utilities.Core sundews/Sundew.Xaml.Optimizer.BuildTask#7

Open

Bump Microsoft.Build and Microsoft.Build.Framework microsoft/sbom-tool#1274

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

drewnoakes drewnoakes left review comments

baronfel baronfel left review comments

rainersigwald rainersigwald left review comments

rokonec rokonec approved these changes

YuliiaKovalova YuliiaKovalova approved these changes

+2 more reviewers

maridematte maridematte approved these changes

ladipro ladipro approved these changes

Labels

None yet