Skip to content

Fix the microbenchmarks build #1662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 12, 2021
Merged

Fix the microbenchmarks build #1662

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
802d1fc
apply [UnsupportedOSPlatform("macos")] attribute to the method that w…
adamsitnik Feb 12, 2021
f8bad49
don't use ValueTask.CompletedTask as it was added in net5.0 and was c…
adamsitnik Feb 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/benchmarks/micro/libraries/System.IO.FileSystem/Perf.FileStream.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,9 @@ public bool OpenClose(long fileSize, FileOptions options)
[Arguments(OneKibibyte , FileOptions.None)]
[Arguments(OneKibibyte , FileOptions.Asynchronous)]
[AllowedOperatingSystems("Lock and Unlock are supported only on Windows and Linux", OS.Linux, OS.Windows)]
#if NET6_0_OR_GREATER // the method was marked as unsupported on macOS in .NET 6.0
[System.Runtime.Versioning.UnsupportedOSPlatform("macos")]
#endif
public void LockUnlock(long fileSize, FileOptions options)
{
string filePath = _sourceFilePaths[fileSize];
Expand Down
2 changes: 1 addition & 1 deletion src/benchmarks/micro/libraries/System.IO/NullWriteStream.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ public override void WriteByte(byte value) { }
#if NETCOREAPP2_1_OR_GREATER // these virtual methods only exist in .NET Core 2.1+
public override void Write(ReadOnlySpan<byte> buffer) { }

public override ValueTask WriteAsync(ReadOnlyMemory<byte> buffer, CancellationToken cancellationToken = default) => ValueTask.CompletedTask;
public override ValueTask WriteAsync(ReadOnlyMemory<byte> buffer, CancellationToken cancellationToken = default) => new ValueTask(Task.CompletedTask);
#endif
}
}