Add PriorityQueue benchmarks #1665
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephentoub
reviewed
Feb 17, 2021
src/benchmarks/micro/libraries/System.Collections/PriorityQueue/Perf_PriorityQueue.cs
Show resolved
Hide resolved
|
Looks like the latest nightly SDK includes PriorityQueue, I presume this is safe to merge now. |
adamsitnik
reviewed
Feb 18, 2021
There was a problem hiding this comment.
Overall looks good to me, but we can use some more of the existing BDN features to simplify the benchmarks. Thank you for adding new benchmarks as soon as it was possible @eiriktsarpalis !
src/benchmarks/micro/libraries/System.Collections/PriorityQueue/Perf_PriorityQueue.cs
Outdated
Show resolved
Hide resolved
src/benchmarks/micro/libraries/System.Collections/PriorityQueue/Perf_PriorityQueue.cs
Outdated
Show resolved
Hide resolved
src/benchmarks/micro/libraries/System.Collections/PriorityQueue/Perf_PriorityQueue.cs
Outdated
Show resolved
Hide resolved
4 tasks
adamsitnik
reviewed
Feb 22, 2021
src/benchmarks/micro/libraries/System.Collections/PriorityQueue/Perf_PriorityQueue.cs
Show resolved
Hide resolved
eiriktsarpalis
force-pushed
the
priorityqueue-benchmarks
branch
from
72f945e to
efce7c9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft PR, requires an SDK build containing PriorityQueue.
Cf. dotnet/runtime#46009