React to NuGet package pruning warnings #11471
Merged
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributes to dotnet/sdk#46642 NuGet added a new feature that automatically prunes package and project references that are provided by the shared framework that is targeted. Resolve the one warning that got emitted when source-building the repository.
akoeplinger
approved these changes
Feb 10, 2025
jjonescz
reviewed
Feb 10, 2025
| <ItemGroup> | ||
| <PackageReference Include="Microsoft.Extensions.ObjectPool" /> | ||
| <PackageReference Include="System.Collections.Immutable" /> | ||
| <PackageReference Include="System.Collections.Immutable" Condition="'$(TargetFrameworkIdentifier)' != '.NETCoreApp'" /> |
There was a problem hiding this comment.
There are transport packages which ship this DLL:
- https://dev.azure.com/dnceng/public/_artifacts/feed/dotnet-tools/NuGet/Microsoft.NET.Sdk.Razor.SourceGenerators.Transport/
- https://dev.azure.com/dnceng/public/_artifacts/feed/dotnet-tools/NuGet/Microsoft.CodeAnalysis.Razor.Tooling.Internal/
But they are only consumed by the SDK, I think, and missing System.Collections.Immutable shouldn't be a problem there.
There was a problem hiding this comment.
This wouldn't be a problem even if the packages would ship publicly. SCI with this given version is already provided by the shared framework. That's why NuGet now flags them as unnecessary package references.
This was referenced Feb 12, 2025
This was referenced Apr 11, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to dotnet/sdk#46642
NuGet added a new feature that automatically prunes package and project references that are provided by the shared framework that is targeted.
Resolve the one warning that got emitted when source-building the repository.