Rationalize ProjectEngineHost a bit #11685
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems this is unused.
- Nest ProjectEngineFactory inside ProjeectEngineFactories, make it private, and rename it to SimpleFactory. - Mark ProjectEngineFactoryProvider as sealed - Mark DefaultProjectEngineFactory as sealed
The is no longer used.
There's a surprising amount of production code checking IsUnsupported() and specific tests calling SetUnsuported() that can be removed.
After calling DocumentContext.GetCodeDocumentAsync(...), it's unnecessary to call DocumentContext.GetSourceTextAync(...). Instead, just use RazorCodeDocument.Source.Text.
ryzngard
approved these changes
Mar 31, 2025
| } | ||
|
|
||
| var codeDocument = await documentContext.GetCodeDocumentAsync(cancellationToken).ConfigureAwait(false); | ||
| if (codeDocument.IsUnsupported()) |
There was a problem hiding this comment.
I'm so happy to see this go 🥳
| } | ||
|
|
||
| var codeDocument = await documentContext.GetCodeDocumentAsync(cancellationToken).ConfigureAwait(false); | ||
| var sourceText = await documentContext.GetSourceTextAsync(cancellationToken).ConfigureAwait(false); |
There was a problem hiding this comment.
not for this PR, but should DocumentContext.GetCodeDocumentAsync populate _sourceText with this value as well? I assume we have the two separated for some optimization where you need sourcetext but not a full RazorCodeDocument
There was a problem hiding this comment.
Yes, that's a very good idea.
|
Thanks for making this easy to review! |
DustinCampbell
changed the base branch from
dev/dustinca/pre-snap-code-clean-up
to
main
davidwengier
approved these changes
Mar 31, 2025
This was referenced Apr 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up to #11675 that cleans up and removes some code in the "ProjectEngineHost" folder. Notably, it turns out that the system for marking projects as "unsupported" is no longer used. So, checks for
RazorCodeDocument.IsUnsupported()can be removed from the language server and tests for this scenario can be removed.NOTE: This PR is currently based onpre-snap-code-clean-upto aid code reviews. I'll rebase it tomainonce #11675 is merged.Changed the base to
main