Skip to content

[release/3.0] Update dependencies from dotnet/arcade aspnet/Extensions #1172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

dotnet-maestro[bot]
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Sep 25, 2019

This pull request updates the following dependencies

From https://github.com/dotnet/arcade

  • Build: 20190924.3
  • Date Produced: 9/24/2019 6:16 PM
  • Commit: 0e9ffd6464aff37aef2dc41dc2162d258f266e32
  • Branch: refs/heads/release/3.x
  • Updates:
    • Microsoft.DotNet.Arcade.Sdk -> 1.0.0-beta.19474.3

From https://github.com/aspnet/Extensions

  • Build: 20191002.3
  • Date Produced: 10/2/2019 7:38 PM
  • Commit: d92e5d70fb47137438f4c614ea9fe6ebddb55407
  • Branch: refs/heads/release/3.0
  • Updates:
    • Microsoft.AspNetCore.BenchmarkRunner.Sources -> 3.0.1-servicing.19502.3
    • Microsoft.AspNetCore.Testing -> 3.0.1-servicing.19502.3
    • Microsoft.Extensions.CommandLineUtils.Sources -> 3.0.1-servicing.19502.3
    • Microsoft.Extensions.NonCapturingTimer.Sources -> 3.0.1-servicing.19502.3
    • Microsoft.Extensions.HashCodeCombiner.Sources -> 3.0.1-servicing.19502.3
    • Microsoft.Extensions.Logging -> 3.0.1-servicing.19502.3

Coherency Updates

The following updates ensure that dependencies with a CoherentParentDependency
attribute were produced in a build used as input to the parent dependency's build.
See Dependency Description Format

  • System.Diagnostics.DiagnosticSource -> 4.6.0 (parent: Microsoft.NETCore.App.Runtime.win-x64)
  • Microsoft.NETCore.App.Runtime.win-x64 -> 3.0.1-servicing-19502-01 (parent: Microsoft.Extensions.Logging)
  • System.Reflection.Metadata -> 1.7.0 (parent: Microsoft.NETCore.App.Runtime.win-x64)
  • System.Text.Encodings.Web -> 4.6.0 (parent: Microsoft.NETCore.App.Runtime.win-x64)
  • Microsoft.Extensions.DependencyModel -> 3.0.1-servicing-19502-01 (parent: Microsoft.Extensions.Logging)
  • Microsoft.NETCore.App.Ref -> 3.0.1-servicing-19502-01 (parent: Microsoft.Extensions.Logging)
  • Microsoft.NETCore.Platforms -> 3.0.1-servicing.19501.4 (parent: Microsoft.NETCore.App.Runtime.win-x64)

…924.3

- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19474.3
@dotnet-maestro dotnet-maestro bot requested review from dougbu and a team as code owners September 25, 2019 16:20
@dotnet-maestro
Copy link
Contributor Author

dotnet-maestro bot commented Sep 25, 2019

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • Standard Merge Policies Unsuccessful checks: AspNetCore-Tooling-ci, AspNetCore-Tooling-ci (Build Windows release), AspNetCore-Tooling-ci (Build Windows debug), AspNetCore-Tooling-ci (Build macOS release), AspNetCore-Tooling-ci (Build Test: Linux Source Build), AspNetCore-Tooling-ci (Build macOS debug), AspNetCore-Tooling-ci (Build Linux release), AspNetCore-Tooling-ci (Build Linux debug)
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.

@wtgodbe
Copy link
Member

wtgodbe commented Sep 25, 2019

F:\workspace_work\1\s\artifacts\toolset\restore.proj : error : Unable to find package Microsoft.DotNet.Arcade.Sdk with version (= 1.0.0-beta.19474.3)

Same as in the Blazor PR - dotnet/blazor#1899

@dotnet-maestro
Copy link
Contributor Author

dotnet-maestro bot commented Sep 25, 2019

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • Standard Merge Policies Unsuccessful checks: AspNetCore-Tooling-ci, AspNetCore-Tooling-ci (Build Windows release), AspNetCore-Tooling-ci (Build Windows debug), AspNetCore-Tooling-ci (Build macOS release), AspNetCore-Tooling-ci (Build Test: Linux Source Build), AspNetCore-Tooling-ci (Build macOS debug), AspNetCore-Tooling-ci (Build Linux release), AspNetCore-Tooling-ci (Build Linux debug)
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.

@dougbu
Copy link
Contributor

dougbu commented Sep 25, 2019

Agreed @wtgodbe

This PR is hitting the known Unable to find package Microsoft.DotNet.Arcade.Sdk with version (= 1.0.0-beta.19474.3) issue. See also aspnet/AspLabs#225

@dotnet-maestro
Copy link
Contributor Author

dotnet-maestro bot commented Sep 25, 2019

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • Standard Merge Policies Unsuccessful checks: AspNetCore-Tooling-ci, AspNetCore-Tooling-ci (Build Windows release), AspNetCore-Tooling-ci (Build Windows debug), AspNetCore-Tooling-ci (Build macOS release), AspNetCore-Tooling-ci (Build Linux release), AspNetCore-Tooling-ci (Build macOS debug), AspNetCore-Tooling-ci (Build Linux debug)
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.

@dougbu
Copy link
Contributor

dougbu commented Sep 26, 2019

@JunTaoLuo @nguerrera you had a conversation about new errors after updating the SDK about duplicate resource identifiers. The specific errors seen here in non-Windows legs start with

CSC : error CS1508: Resource identifier 'AspNetCore.TestFiles_IntegrationTests_CodeGenerationIntegrationTest_AttributeDirectiveWithViewImports' has already been used in this assembly [/Users/vsts/agent/2.155.1/work/1/s/src/Razor/test/Microsoft.AspNetCore.Mvc.Razor.Extensions.Test/Microsoft.AspNetCore.Mvc.Razor.Extensions.Test.csproj]

@MattGal this repo uses the BYOC pools, specifically NetCorePublic-Pool / BuildPool.Windows.10.Amd64.VS2019.Open, and the Windows legs of this build hit

F:\workspace\_work\1\s\.packages\microsoft.dotnet.arcade.sdk\1.0.0-beta.19474.3\tools\Tools.proj : error : Version 3.0.100 of the .NET Core SDK requires at least version 16.3.0 of MSBuild. The current available version of MSBuild is 16.2.37902.0. Change the .NET Core SDK specified in global.json to an older version that requires the MSBuild version currently available.

Any chance the VS instance on these agents will be upgraded to 16.3.0 in the near future?

@dougbu
Copy link
Contributor

dougbu commented Sep 26, 2019

Forgot to ask ☹️: @JunTaoLuo @nguerrera what was the upshot of your conversation? Is there a workaround for this new SDK / compiler behaviour / bug?

@dotnet-maestro
Copy link
Contributor Author

dotnet-maestro bot commented Sep 26, 2019

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • Standard Merge Policies Unsuccessful checks: AspNetCore-Tooling-ci, AspNetCore-Tooling-ci (Build Linux release), AspNetCore-Tooling-ci (Build Linux debug), AspNetCore-Tooling-ci (Build Windows release), AspNetCore-Tooling-ci (Build Windows debug), AspNetCore-Tooling-ci (Build macOS release), AspNetCore-Tooling-ci (Build macOS debug)
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.

…0190925.1

- Microsoft.AspNetCore.BenchmarkRunner.Sources - 3.0.0-rc2.19475.1
- Microsoft.AspNetCore.Testing - 3.0.0-rc2.19475.1
- Microsoft.Extensions.CommandLineUtils.Sources - 3.0.0-rc2.19475.1
- Microsoft.Extensions.HashCodeCombiner.Sources - 3.0.0-rc2.19475.1
- Microsoft.Extensions.NonCapturingTimer.Sources - 3.0.0-rc2.19475.1
- Microsoft.Extensions.Logging - 3.0.0
@dotnet-maestro dotnet-maestro bot changed the title [release/3.0] Update dependencies from dotnet/arcade [release/3.0] Update dependencies from dotnet/arcade aspnet/Extensions Sep 26, 2019
@wtgodbe
Copy link
Member

wtgodbe commented Sep 27, 2019

ping @JunTaoLuo @nguerrera - did you guys figure anything out with respect to:

CSC : error CS1508: Resource identifier 'AspNetCore.TestFiles_IntegrationTests_CodeGenerationIntegrationTest_AttributeDirectiveWithViewImports' has already been used in this assembly [/Users/vsts/agent/2.155.1/work/1/s/src/Razor/test/Microsoft.AspNetCore.Mvc.Razor.Extensions.Test/Microsoft.AspNetCore.Mvc.Razor.Extensions.Test.csproj]

@dotnet-maestro
Copy link
Contributor Author

dotnet-maestro bot commented Sep 27, 2019

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • Standard Merge Policies Unsuccessful checks: AspNetCore-Tooling-ci, AspNetCore-Tooling-ci (Build Windows release), AspNetCore-Tooling-ci (Build Windows debug)
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.

…0190927.3

- Microsoft.AspNetCore.BenchmarkRunner.Sources - 3.0.1-servicing.19477.3
- Microsoft.AspNetCore.Testing - 3.0.1-servicing.19477.3
- Microsoft.Extensions.CommandLineUtils.Sources - 3.0.1-servicing.19477.3
- Microsoft.Extensions.NonCapturingTimer.Sources - 3.0.1-servicing.19477.3
- Microsoft.Extensions.HashCodeCombiner.Sources - 3.0.1-servicing.19477.3
- Microsoft.Extensions.Logging - 3.0.1-servicing.19477.3
…0190927.5

- Microsoft.AspNetCore.BenchmarkRunner.Sources - 3.0.1-servicing.19477.5
- Microsoft.AspNetCore.Testing - 3.0.1-servicing.19477.5
- Microsoft.Extensions.CommandLineUtils.Sources - 3.0.1-servicing.19477.5
- Microsoft.Extensions.NonCapturingTimer.Sources - 3.0.1-servicing.19477.5
- Microsoft.Extensions.HashCodeCombiner.Sources - 3.0.1-servicing.19477.5
- Microsoft.Extensions.Logging - 3.0.1-servicing.19477.5
…0190927.6

- Microsoft.AspNetCore.BenchmarkRunner.Sources - 3.0.1-servicing.19477.6
- Microsoft.AspNetCore.Testing - 3.0.1-servicing.19477.6
- Microsoft.Extensions.CommandLineUtils.Sources - 3.0.1-servicing.19477.6
- Microsoft.Extensions.NonCapturingTimer.Sources - 3.0.1-servicing.19477.6
- Microsoft.Extensions.HashCodeCombiner.Sources - 3.0.1-servicing.19477.6
- Microsoft.Extensions.Logging - 3.0.1-servicing.19477.6
@MattGal
Copy link
Member

MattGal commented Sep 30, 2019

@JunTaoLuo @nguerrera you had a conversation about new errors after updating the SDK about duplicate resource identifiers. The specific errors seen here in non-Windows legs start with

CSC : error CS1508: Resource identifier 'AspNetCore.TestFiles_IntegrationTests_CodeGenerationIntegrationTest_AttributeDirectiveWithViewImports' has already been used in this assembly [/Users/vsts/agent/2.155.1/work/1/s/src/Razor/test/Microsoft.AspNetCore.Mvc.Razor.Extensions.Test/Microsoft.AspNetCore.Mvc.Razor.Extensions.Test.csproj]

@MattGal this repo uses the BYOC pools, specifically NetCorePublic-Pool / BuildPool.Windows.10.Amd64.VS2019.Open, and the Windows legs of this build hit

F:\workspace\_work\1\s\.packages\microsoft.dotnet.arcade.sdk\1.0.0-beta.19474.3\tools\Tools.proj : error : Version 3.0.100 of the .NET Core SDK requires at least version 16.3.0 of MSBuild. The current available version of MSBuild is 16.2.37902.0. Change the .NET Core SDK specified in global.json to an older version that requires the MSBuild version currently available.

Any chance the VS instance on these agents will be upgraded to 16.3.0 in the near future?

I think this is already known but we're actively updating our VS 2019 BYOC images as fast as we can, hoping to have something tomorrow.

@dotnet-maestro
Copy link
Contributor Author

dotnet-maestro bot commented Sep 30, 2019

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • Standard Merge Policies Unsuccessful checks: AspNetCore-Tooling-ci, AspNetCore-Tooling-ci (Build Windows release), AspNetCore-Tooling-ci (Build Windows debug)
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.

@nguerrera
Copy link
Contributor

See dotnet/msbuild#4764, that error is likely due to that.

@nguerrera
Copy link
Contributor

also adding @rainersigwald

@dotnet-maestro
Copy link
Contributor Author

dotnet-maestro bot commented Oct 1, 2019

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • Standard Merge Policies Unsuccessful checks: AspNetCore-Tooling-ci, AspNetCore-Tooling-ci (Build Windows release), AspNetCore-Tooling-ci (Build Windows debug)
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.

…0191002.3

- Microsoft.AspNetCore.BenchmarkRunner.Sources - 3.0.1-servicing.19502.3
- Microsoft.AspNetCore.Testing - 3.0.1-servicing.19502.3
- Microsoft.Extensions.CommandLineUtils.Sources - 3.0.1-servicing.19502.3
- Microsoft.Extensions.NonCapturingTimer.Sources - 3.0.1-servicing.19502.3
- Microsoft.Extensions.HashCodeCombiner.Sources - 3.0.1-servicing.19502.3
- Microsoft.Extensions.Logging - 3.0.1-servicing.19502.3

Dependency coherency updates

- System.Diagnostics.DiagnosticSource - 4.6.0 (parent: Microsoft.NETCore.App.Runtime.win-x64)
- Microsoft.NETCore.App.Runtime.win-x64 - 3.0.1-servicing-19502-01 (parent: Microsoft.Extensions.Logging)
- System.Reflection.Metadata - 1.7.0 (parent: Microsoft.NETCore.App.Runtime.win-x64)
- System.Text.Encodings.Web - 4.6.0 (parent: Microsoft.NETCore.App.Runtime.win-x64)
- Microsoft.Extensions.DependencyModel - 3.0.1-servicing-19502-01 (parent: Microsoft.Extensions.Logging)
- Microsoft.NETCore.App.Ref - 3.0.1-servicing-19502-01 (parent: Microsoft.Extensions.Logging)
- Microsoft.NETCore.Platforms - 3.0.1-servicing.19501.4 (parent: Microsoft.NETCore.App.Runtime.win-x64)
@dougbu
Copy link
Contributor

dougbu commented Oct 3, 2019

/azp run all

@azure-pipelines
Copy link

No pipelines are associated with this pull request.

@dougbu
Copy link
Contributor

dougbu commented Oct 3, 2019

/azp run AspNetCore-Tooling-ci

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@dotnet-maestro
Copy link
Contributor Author

dotnet-maestro bot commented Oct 3, 2019

Auto-Merge Status

This pull request will be merged because the following merge policies have succeeded.

  • ✔️ Standard Merge Policies Succeeded - Successful checks: AspNetCore-Tooling-ci, AspNetCore-Tooling-ci (Build macOS release), AspNetCore-Tooling-ci (Build macOS debug), AspNetCore-Tooling-ci (Build Windows release), AspNetCore-Tooling-ci (Build Linux release), AspNetCore-Tooling-ci (Build Windows debug), AspNetCore-Tooling-ci (Build Linux debug), AspNetCore-Tooling-ci (Build Code check), AspNetCore-Tooling-ci (Build Test: Linux Source Build)
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.

@dougbu dougbu merged commit fa3adaa into release/3.0 Oct 3, 2019
@dougbu dougbu deleted the darc-release/3.0-21ffa3d2-0876-4c14-b4ff-4e69c05675c7 branch October 3, 2019 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants