Skip to content

Address a few minor IDE warnings #1039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 24, 2019
Merged

Address a few minor IDE warnings #1039

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Ix.NET/Source/Benchmarks.System.Interactive/Program.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ namespace Benchmarks.System.Interactive
{
internal class Program
{
internal static void Main(string[] args)
internal static void Main()
{
Console.WriteLine("Effective Ix-version: " + typeof(EnumerableEx).Assembly.GetName().Version);

Expand Down
2 changes: 1 addition & 1 deletion Ix.NET/Source/System.Interactive.Async.Providers.Tests/AssertEx.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ internal static void SucceedOrFailProper(Action action)
}
catch (AggregateException ex)
{
var inner = ex.Flatten().InnerException;
_ = ex.Flatten().InnerException;

// TODO: proper assert; unfortunately there's not always a good call stack
}
Expand Down
3 changes: 1 addition & 2 deletions Ix.NET/Source/System.Interactive.Async.Tests/System/Linq/Operators/Never.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
// The .NET Foundation licenses this file to you under the Apache 2.0 License.
// See the LICENSE file in the project root for more information.

using System;
using System.Linq;
using System.Threading;
using System.Threading.Tasks;
Expand All @@ -25,7 +24,7 @@ public async Task Never1()
[Fact]
public async Task CancelToken_UnblocksAsync()
{
var cts = new CancellationTokenSource();
using var cts = new CancellationTokenSource();

var en = AsyncEnumerableEx.Never<int>().GetAsyncEnumerator(cts.Token);

Expand Down
2 changes: 1 addition & 1 deletion Ix.NET/Source/System.Interactive.Tests/AssertEx.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ internal static void SucceedOrFailProper(Action action)
}
catch (AggregateException ex)
{
var inner = ex.Flatten().InnerException;
_ = ex.Flatten().InnerException;

// TODO: proper assert; unfortunately there's not always a good call stack
}
Expand Down
2 changes: 1 addition & 1 deletion Ix.NET/Source/System.Interactive.Tests/System/Linq/Operators/Publish.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,7 @@ public void Publish6()
AssertThrows<MyException>(() => e2.MoveNext());
}

class MyException : Exception
private class MyException : Exception
{
}

Expand Down
2 changes: 1 addition & 1 deletion Ix.NET/Source/System.Interactive/System/Linq/Operators/IgnoreElements.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ public static IEnumerable<TSource> IgnoreElements<TSource>(this IEnumerable<TSou

private static IEnumerable<TSource> IgnoreElementsCore<TSource>(IEnumerable<TSource> source)
{
foreach (var item in source)
foreach (var _ in source)
;

yield break;
Expand Down
2 changes: 1 addition & 1 deletion Ix.NET/Source/System.Linq.Async.Queryable.Tests/AssertEx.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ internal static void SucceedOrFailProper(Action action)
}
catch (AggregateException ex)
{
var inner = ex.Flatten().InnerException;
_ = ex.Flatten().InnerException;

// TODO: proper assert; unfortunately there's not always a good call stack
}
Expand Down
12 changes: 6 additions & 6 deletions Ix.NET/Source/System.Linq.Async.Tests/System/Linq/Operators/ToAsyncEnumerable.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -286,7 +286,7 @@ public async Task ToAsyncEnumerable_Observable_Throw()
[Fact]
public async Task ToAsyncEnumerable_Observable_Dispose()
{
var stop = new ManualResetEvent(false);
using var stop = new ManualResetEvent(false);

var xs = new MyObservable<int>(obs =>
{
Expand Down Expand Up @@ -320,9 +320,9 @@ public async Task ToAsyncEnumerable_Observable_Dispose()
[Fact]
public async Task ToAsyncEnumerable_Observable_Zip()
{
var subCount = 0;
using var stop = new ManualResetEvent(false);

var stop = new ManualResetEvent(false);
var subCount = 0;

var xs = new MyObservable<int>(obs =>
{
Expand Down Expand Up @@ -360,7 +360,7 @@ public async Task ToAsyncEnumerable_Observable_Zip()
[Fact]
public async Task ToAsyncEnumerable_Observable_Cancel()
{
var stop = new ManualResetEvent(false);
using var stop = new ManualResetEvent(false);

var xs = new MyObservable<int>(obs =>
{
Expand All @@ -380,7 +380,7 @@ public async Task ToAsyncEnumerable_Observable_Cancel()
return new MyDisposable(cts.Cancel);
}).ToAsyncEnumerable();

var c = new CancellationTokenSource();
using var c = new CancellationTokenSource();

var e = xs.GetAsyncEnumerator(c.Token);

Expand All @@ -396,7 +396,7 @@ public async Task ToAsyncEnumerable_Observable_Cancel()
[Fact]
public async Task ToAsyncEnumerable_Observable6_Async()
{
var stop = new ManualResetEvent(false);
using var stop = new ManualResetEvent(false);

var xs = new MyObservable<int>(obs =>
{
Expand Down
21 changes: 14 additions & 7 deletions Ix.NET/Source/System.Linq.Async.Tests/System/Linq/Operators/ToObservable.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,9 @@ public void ToObservable_Null()
[Fact]
public void ToObservable1()
{
using var evt = new ManualResetEvent(false);

var fail = false;
var evt = new ManualResetEvent(false);

var xs = AsyncEnumerable.Empty<int>().ToObservable();
xs.Subscribe(new MyObserver<int>(
Expand All @@ -49,9 +50,10 @@ public void ToObservable1()
[Fact]
public void ToObservable2()
{
using var evt = new ManualResetEvent(false);

var lst = new List<int>();
var fail = false;
var evt = new ManualResetEvent(false);

var xs = Return42.ToObservable();
xs.Subscribe(new MyObserver<int>(
Expand All @@ -78,9 +80,10 @@ public void ToObservable2()
[Fact]
public void ToObservable3()
{
using var evt = new ManualResetEvent(false);

var lst = new List<int>();
var fail = false;
var evt = new ManualResetEvent(false);

var xs = AsyncEnumerable.Range(0, 10).ToObservable();
xs.Subscribe(new MyObserver<int>(
Expand All @@ -107,10 +110,11 @@ public void ToObservable3()
[Fact]
public void ToObservable4()
{
using var evt = new ManualResetEvent(false);

var ex1 = new Exception("Bang!");
var ex_ = default(Exception);
var fail = false;
var evt = new ManualResetEvent(false);

var xs = Throw<int>(ex1).ToObservable();
xs.Subscribe(new MyObserver<int>(
Expand Down Expand Up @@ -138,8 +142,9 @@ public void ToObservable4()
[Fact]
public void ToObservable_DisposesEnumeratorOnCompletion()
{
using var evt = new ManualResetEvent(false);

var fail = false;
var evt = new ManualResetEvent(false);

var ae = AsyncEnumerable.Create(
_ => AsyncEnumerator.Create<int>(
Expand Down Expand Up @@ -170,8 +175,9 @@ public void ToObservable_DisposesEnumeratorOnCompletion()
[Fact]
public void ToObservable_DisposesEnumeratorWhenSubscriptionIsDisposed()
{
using var evt = new ManualResetEvent(false);

var fail = false;
var evt = new ManualResetEvent(false);
var subscription = default(IDisposable);
var subscriptionAssignedTcs = new TaskCompletionSource<object>();

Expand Down Expand Up @@ -216,9 +222,10 @@ public void ToObservable_DisposesEnumeratorWhenSubscriptionIsDisposed()
[Fact]
public void ToObservable_DesNotCallMoveNextAgainWhenSubscriptionIsDisposed()
{
using var evt = new ManualResetEvent(false);

var fail = false;
var moveNextCount = 0;
var evt = new ManualResetEvent(false);
var subscription = default(IDisposable);
var subscriptionAssignedTcs = new TaskCompletionSource<object>();

Expand Down