-
Notifications
You must be signed in to change notification settings - Fork 766
Fixes for EF issues #185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Fixes for EF issues #185
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note that this is 3.0.1 as per request of the EF team to keep this out of 3.0 given the timeframe. |
|
||
if (_innerGroups == null) | ||
{ | ||
_innerGroups = new Dictionary<TKey, List<TInner>>(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use comparer?
I'm going to expand this PR to include #200 as the EF specific fixes are a subset of that. |
closing this in favor of #170 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes
#182
and
#183
Note that the fixes for these involve incorporating
await
. This means we need theMicrosoft.Bcl.Async
library to support .NET 4.0....or we drop .NET 4.0 support. Dropping .NET 4 means we can avoid any potential issues with the BCL Async tools./cc @bartdesmet @shiftkey @natemcmaster @mattpodwysocki
This change is