Skip to content

Fixes for EF issues #185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 8 commits into from
Closed

Fixes for EF issues #185

wants to merge 8 commits into from

Conversation

clairernovotny
Copy link
Contributor

@clairernovotny clairernovotny commented Jun 16, 2016

This PR fixes

#182
and
#183

Note that the fixes for these involve incorporating await. This means we need the Microsoft.Bcl.Async library to support .NET 4.0....or we drop .NET 4.0 support. Dropping .NET 4 means we can avoid any potential issues with the BCL Async tools.

/cc @bartdesmet @shiftkey @natemcmaster @mattpodwysocki


This change is Reviewable

@clairernovotny clairernovotny added this to the 3.0.1 milestone Jun 16, 2016
@clairernovotny
Copy link
Contributor Author

clairernovotny commented Jun 16, 2016

Note that this is 3.0.1 as per request of the EF team to keep this out of 3.0 given the timeframe.


if (_innerGroups == null)
{
_innerGroups = new Dictionary<TKey, List<TInner>>();
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use comparer?

@clairernovotny
Copy link
Contributor Author

I'm going to expand this PR to include #200 as the EF specific fixes are a subset of that.

@clairernovotny
Copy link
Contributor Author

closing this in favor of #170

@clairernovotny clairernovotny deleted the EF-fixes branch July 10, 2016 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants