fix removing elements other than top #329
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Honestly I don't know how PriorityQueue should behave or how it is working, but if this PR intends to fix a bug, there should be an unit test verifying the fix and also showing the bug in the current version. |
|
@astrofishgames Could you give us some insight of what this PR fixes, i.e. could you provide a unit test that would fail without the fix ? |
Merged
|
I reproduced the bug and rebased the fix from this PR onto the lastest master, closing this in favor of https://github.com/dotnet/reactive/pull/569/commits. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.