4.x: Improve AutoDetachObserver memory footprint #506
Conversation
| set { _disposable.Disposable = value; } | ||
| set | ||
| { | ||
| if (Interlocked.CompareExchange(ref disposable, value, null) != null) |
There was a problem hiding this comment.
I wonder whether we can refactor that reoccuring logic into extensions that take refs, taking the idea from AssignmentDisposable a bit further.
There was a problem hiding this comment.
The Setter-extensions could be called "SetSingle", "SetMultiple" etc....
There was a problem hiding this comment.
Yes, I do this in my repo but this is dotnet/reactive.
The problem with such PRs is that if you need an utility for multiple other PRs as well, either it has to be PRd separately and then merged before anything in new PRs can use it.
There was a problem hiding this comment.
Yes, I do this in my repo but this is dotnet/reactive.
Awesome!
...then merged before anything in new PRs can use it.
Let's hope any of our work will be merged eventually. Until then, we could agree on some basic improvements (like the import of ValueTuples, those extensions etc.) on a separate branch and rebase all our PRs on that branch.
This PR inlines the
SingleAssignmentDisposablebehavior into theAutoDetachObserverto save on an allocation and the indirection.