Capture the concept of a "safe observer" #597
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…opied multiple times in the repo. ISafeObserver implements IDisposable and IObserver and can hold onto a resource. Implementors must at least dispose the resource on disposal of the SafeObserver, inheriting classes may choose to dispose the resource on other occasions as well. So far, AnonymousSafeObserver, SafeObserver and ObserverWithToken work like that are have been changed to implement ISafeObserver.
…t. It will be set in the Producers.
akarnokd
approved these changes
Jun 15, 2018
akarnokd
reviewed
Jun 15, 2018
| @@ -46,7 +46,9 @@ public IDisposable SubscribeRaw(IObserver<TSource> observer, bool enableSafeguar | |||
| // | |||
| if (enableSafeguard) | |||
| { | |||
| observer = SafeObserver<TSource>.Create(observer, subscription); | |||
| var safeObserver = SafeObserver<TSource>.Create(observer); | |||
| safeObserver.SetResource(subscription); | |||
There was a problem hiding this comment.
Could the initialization of this subscription also be eliminated just like in the other Producer variant (in another PR of course)?
There was a problem hiding this comment.
Got it already covered in a separate PR!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Capture the concept of a "safe observer" since it has been used and copied multiple times in the repo. ISafeObserver implements IDisposable and IObserver and can hold onto a resource. Implementors must at least dispose the resource on disposal of the SafeObserver, inheriting classes may choose to dispose the resource on other occasions as well. So far, AnonymousSafeObserver, SafeObserver and ObserverWithToken work like that are have been changed to implement ISafeObserver.