Skip to content

An allocation in BasicProducer.SubscribeRaw can be saved in most cases. #602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 19, 2018
Merged

An allocation in BasicProducer.SubscribeRaw can be saved in most cases. #602

merged 3 commits into from
Jun 19, 2018

Conversation

danielcweber
Copy link
Collaborator

No description provided.

danielcweber
danielcweber commented Jun 18, 2018
View reviewed changes
Rx.NET/Source/src/System.Reactive/Internal/Producer.cs Outdated
var safeObserver = SafeObserver<TSource>.Create(observer);
safeObserver.SetResource(subscription);
observer = safeObserver;
observer = safeObserver = SafeObserver<TSource>.Create(observer);
}

if (CurrentThreadScheduler.IsScheduleRequired)
{
Copy link
Collaborator Author

@danielcweber danielcweber Jun 18, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@akarnokd Can you please review again, it occured to me that on this path, the safeObserver is not assigned the resource. I guess I may have introduced a bug here.

Copy link
Collaborator Author

@danielcweber danielcweber Jun 18, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be fixed by 0a964a5

@danielcweber danielcweber reopened this Jun 18, 2018
akarnokd
akarnokd approved these changes Jun 18, 2018
View reviewed changes
Copy link
Collaborator

@akarnokd akarnokd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It just skipped the safeObserver without affecting the dispose path. The unit tests usually fail when you make a mistake with the dispose chains.

@danielcweber danielcweber merged commit a8385a8 into dotnet:master Jun 19, 2018
@danielcweber danielcweber deleted the SaveAllocationInBasicProducer branch June 19, 2018 10:31
@akarnokd akarnokd mentioned this pull request Jul 24, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akarnokd akarnokd akarnokd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danielcweber @akarnokd