4.x: ElementAt don't create exception after finding the item #671
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
ElementAt
finds an item, it disposes the upstream, however, the upstream may still emit anOnCompleted
if it is unable to detect this dispose call (or ignores it). In this case, theElementAt
'sOnCompleted
gets invoked which creates an exception that gets thrown away as the base observer is already the no-op observer, wasting resources creating the stacktrace in the process.I don't know how to verify this via unit test, but this extra call can be seen when placing a breakpoint in
ElementAt
'sOnCompleted
method and running this flow: