Skip to content

4.x: Min() don't initialize to default values #680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 28, 2018
Merged

4.x: Min() don't initialize to default values #680

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 0 additions & 18 deletions Rx.NET/Source/src/System.Reactive/Linq/Observable/Min.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,6 @@ private sealed class NonNull : _
public NonNull(IComparer<TSource> comparer, IObserver<TSource> observer)
: base(comparer, observer)
{
_hasValue = false;
_lastValue = default(TSource);
}

public override void OnNext(TSource value)
Expand Down Expand Up @@ -98,7 +96,6 @@ private sealed class Null : _
public Null(IComparer<TSource> comparer, IObserver<TSource> observer)
: base(comparer, observer)
{
_lastValue = default(TSource);
}

public override void OnNext(TSource value)
Expand Down Expand Up @@ -160,8 +157,6 @@ internal sealed class _ : IdentitySink<double>
public _(IObserver<double> observer)
: base(observer)
{
_hasValue = false;
_lastValue = default(double);
}

public override void OnNext(double value)
Expand Down Expand Up @@ -216,8 +211,6 @@ internal sealed class _ : IdentitySink<float>
public _(IObserver<float> observer)
: base(observer)
{
_hasValue = false;
_lastValue = default(float);
}

public override void OnNext(float value)
Expand Down Expand Up @@ -272,8 +265,6 @@ internal sealed class _ : IdentitySink<decimal>
public _(IObserver<decimal> observer)
: base(observer)
{
_hasValue = false;
_lastValue = default(decimal);
}

public override void OnNext(decimal value)
Expand Down Expand Up @@ -328,8 +319,6 @@ internal sealed class _ : IdentitySink<int>
public _(IObserver<int> observer)
: base(observer)
{
_hasValue = false;
_lastValue = default(int);
}

public override void OnNext(int value)
Expand Down Expand Up @@ -384,8 +373,6 @@ internal sealed class _ : IdentitySink<long>
public _(IObserver<long> observer)
: base(observer)
{
_hasValue = false;
_lastValue = default(long);
}

public override void OnNext(long value)
Expand Down Expand Up @@ -439,7 +426,6 @@ internal sealed class _ : IdentitySink<double?>
public _(IObserver<double?> observer)
: base(observer)
{
_lastValue = default(double?);
}

public override void OnNext(double? value)
Expand Down Expand Up @@ -488,7 +474,6 @@ internal sealed class _ : IdentitySink<float?>
public _(IObserver<float?> observer)
: base(observer)
{
_lastValue = default(float?);
}

public override void OnNext(float? value)
Expand Down Expand Up @@ -537,7 +522,6 @@ internal sealed class _ : IdentitySink<decimal?>
public _(IObserver<decimal?> observer)
: base(observer)
{
_lastValue = default(decimal?);
}

public override void OnNext(decimal? value)
Expand Down Expand Up @@ -586,7 +570,6 @@ internal sealed class _ : IdentitySink<int?>
public _(IObserver<int?> observer)
: base(observer)
{
_lastValue = default(int?);
}

public override void OnNext(int? value)
Expand Down Expand Up @@ -635,7 +618,6 @@ internal sealed class _ : IdentitySink<long?>
public _(IObserver<long?> observer)
: base(observer)
{
_lastValue = default(long?);
}

public override void OnNext(long? value)
Expand Down