Skip to content

Conversation

akarnokd
Copy link
Collaborator

  • Simplify default(X) where X is inferable from the usage.
  • Aggregate:
    • don't initialize to default values
    • clear accumulation upon failure or completion
  • LastAsync:
    • don't initialize to default values
    • clear accumulation upon failure or completion
  • LastOrDefaultAsync:
    • don't initialize to default values
    • clear accumulation upon failure or completion
  • Upgrade Test.System.Reactive project to C# 7.1

@danielcweber danielcweber merged commit 0d41a88 into dotnet:master Jun 29, 2018
@@ -2,6 +2,7 @@
<PropertyGroup>
<TargetFrameworks>net46;netcoreapp2.0</TargetFrameworks>
<NoWarn>$(NoWarn);CS0618</NoWarn>
<LangVersion>7.1</LangVersion>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be removed. The LangVersion is set to latest in the Directory.Build.props. This lowers it.

@akarnokd akarnokd deleted the SimplifyDefaultExpr branch June 29, 2018 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants