Skip to content

4.x: Upgrade the ObserveOn operator to IdentitySink, fix queue usage #742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 3, 2018
Merged

4.x: Upgrade the ObserveOn operator to IdentitySink, fix queue usage #742

merged 1 commit into from
Jul 3, 2018

Conversation

akarnokd
Copy link
Collaborator

@akarnokd akarnokd commented Jul 3, 2018

  • Upgrade the ObserveOnObserverNew to be an IdentitySink
  • Use the argument q inside DrainStep
  • Document more explicitly why DrainStep uses an argument instead of the _queue field (to avoid re-reads mandated by the memory model, even though the field is readonly).

@danielcweber danielcweber merged commit 89cde7a into dotnet:master Jul 3, 2018
@akarnokd akarnokd deleted the ObserveOnQueueAccess branch July 4, 2018 16:11
@akarnokd akarnokd mentioned this pull request Jul 24, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@akarnokd @danielcweber