Add Android network security configuration #251
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It would be preferable to extract existing certificates but I think this is acceptable for now. We can revisit this later. |
|
These certificates are extracted from |
akoeplinger
approved these changes
Jul 7, 2022
|
@wfurt is it OK to merge this PR? |
wfurt
approved these changes
Jul 9, 2022
simonrozsival
added a commit
to simonrozsival/runtime-assets
that referenced
this pull request
Jan 13, 2023
…Data (dotnet#251)" This reverts commit 4cb6664.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to run tests against servers with self-signed certificates on Android, we need to instruct Android to trust those certificates through Network security configuration.
We need these assets to address dotnet/runtime#69870, dotnet/runtime#68206, dotnet/runtime#37087 (see WIP PR dotnet/runtime#71385).