Skip to content

Commit 6a8603b

Browse files
authored
Attempt to fix restore internal tools (#2255)
* Force re-install of nuget authenticator * Update dotnet tools to latest daily build * Remove AddUntrackedResourcesForSourceLink workaround for sourcelink
1 parent 2cf4433 commit 6a8603b

File tree

5 files changed

+4
-15
lines changed

5 files changed

+4
-15
lines changed

eng/pipelines/common/restore-internal-tools.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@ steps:
1313
- task: NuGetAuthenticate@0
1414
inputs:
1515
nuGetServiceConnections: 'dotnet-core-internal-tooling'
16+
forceReinstallCredentialProvider: true
1617

1718
- task: DotNetCoreCLI@2
1819
displayName: Restore internal tools

eng/pipelines/libraries/base-job.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,7 @@ jobs:
4747
- _warnAsErrorArg: ''
4848
- _testScopeArg: ''
4949
- _extraHelixArguments: ''
50+
- _crossBuildPropertyArg: ''
5051

5152
- librariesBuildArtifactName: ${{ format('libraries_bin_{0}{1}_{2}_{3}', parameters.osGroup, parameters.osSubgroup, parameters.archType, parameters.buildConfig) }}
5253

global.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
"rollForward": "major"
66
},
77
"tools": {
8-
"dotnet": "5.0.100-alpha1-015772"
8+
"dotnet": "5.0.100-alpha.1.20073.4"
99
},
1010
"native-tools": {
1111
"cmake": "3.14.2",

src/coreclr/src/System.Private.CoreLib/System.Private.CoreLib.csproj

Lines changed: 1 addition & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -109,7 +109,6 @@
109109
<PropertyGroup>
110110
<!-- This is needed to embed build-time generated sources such as eventing and resource files to sourcelink PDBs. -->
111111
<EmbedUntrackedSources>true</EmbedUntrackedSources>
112-
<CoreCompileDependsOn>$(CoreCompileDependsOn);AddUntrackedResourcesForSourceLink</CoreCompileDependsOn>
113112
</PropertyGroup>
114113

115114
<!--
@@ -456,16 +455,5 @@
456455

457456
<Import Project="CreateRuntimeRootILLinkDescriptorFile.targets" />
458457

459-
<Target Name="CreateRuntimeRootIlLinkDescFile" BeforeTargets="CoreCompile" DependsOnTargets="_CreateILLinkRuntimeRootDescriptorFile">
460-
</Target>
461-
462-
<!-- This is working around dotnet/coreclr#26371 until dotnet/sourcelink#392 gets solved -->
463-
<Target Name="AddUntrackedResourcesForSourceLink"
464-
Condition="'$(BuildingInsideVisualStudio)' != 'true'"
465-
BeforeTargets="CoreCompile"
466-
DependsOnTargets="SetEmbeddedFilesFromSourceControlManagerUntrackedFiles;_GenerateResxSource" >
467-
<ItemGroup>
468-
<EmbeddedFiles Include="@(GeneratedResxSource)" />
469-
</ItemGroup>
470-
</Target>
458+
<Target Name="CreateRuntimeRootIlLinkDescFile" BeforeTargets="CoreCompile" DependsOnTargets="_CreateILLinkRuntimeRootDescriptorFile"/>
471459
</Project>

src/mono/netcore/System.Private.CoreLib/System.Private.CoreLib.csproj

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -115,7 +115,6 @@
115115
<PropertyGroup>
116116
<!-- This is needed to embed build-time generated sources such as eventing and resource files to sourcelink PDBs. -->
117117
<EmbedUntrackedSources>true</EmbedUntrackedSources>
118-
<CoreCompileDependsOn>$(CoreCompileDependsOn);AddUntrackedResourcesForSourceLink</CoreCompileDependsOn>
119118
</PropertyGroup>
120119

121120
<!--

0 commit comments

Comments
 (0)