Attempt to fix restore internal tools #2255
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ViktorHofer
approved these changes
Jan 27, 2020
|
I removed workaround for https://github.com/dotnet/coreclr/issues/26371 which was causing the build to fail due to target not existing on mono. Based on the issues it seems like it is not needed. I validated locally and it seems like sourcelink worked correctly with embedded files, i.e:
cc: @hoyosjs |
dagood
approved these changes
Jan 28, 2020
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempts to fix: #2199
Arcade templates install NugetAuthenticator always, and then we were re-installing it with a service credential, but it wasn't installed because there was already one installed. So I'm forcing our installation.
Also, update the SDK we use to the latest daily build which fixes a lot of reliability bugs in NuGet.
I added an empty variable declaration that someone missed in another change causing a wrong parameter to be passed down when it was not declared.
Note: I ran 2 official builds from my branch and they didn't hit the issue anymore
cc: @dotnet/runtime-infrastructure