Pri-1 tests broken as of #18695

[tannergooding]

All pri-1 JitStress jobs started failing after dotnet/coreclr#18695 was merged.

I have validated locally that reverting f5f9a34 fixes the issue.

[tannergooding]

FYI. @jashook, @AaronRobinsonMSFT, @sbomer

[jashook]

Should have some time today/tomorrow to look. If I do not get to it by Monday ill assign to Sven.

[AaronRobinsonMSFT]

@tannergooding Can you elaborate on what is failing? Build? Run? How are the tests failing? Do you have an example of the point of failure?

[tannergooding]

@AaronRobinsonMSFT, see https://ci.dot.net/job/dotnet_coreclr/job/master/job/jitstress/job/x64_checked_windows_nt_jitstress1/577/ for more details.

Build succeeds, running tests fails with:

The command
"D:\j\workspace\x64_checked_w---02832afb\tests\..\bin\tests\Windows_NT.x64.Checked\Tests\Core_Root\corerun.exe D:\j\workspace\x64_checked_w---02832afb\tests\..\bin\tests\Windows_NT.x64.Checked\Tests\Core_Root\xunit.console.dll
...
-parallel all -html D:\j\workspace\x64_checked_w---02832afb\tests\..\bin\Logs\TestRun_Windows_NT__x64__Checked.html -xml D:\j\workspace\x64_checked_w---02832afb\tests\..\bin\Logs\TestRun_Windows_NT__x64__Checked.xml  -notrait category=outerloop -notrait category=failing"
exited with code -532462766

[tannergooding]

All other JitStress jobs that run pri1 tests (and that I looked at, which was a number of them) have the same failures. Some quick PR links are on the failures here: dotnet/coreclr#19062

[jashook]

I am able to repro the failure locally by passing testenv. It looks as if the pri1 tests are actually building correctly, I have a feeling that the test env being passed along is broken.

Will investigate further.

[sbomer]

Thanks for looking into this @jashook! I noticed the following in the PR failure @tannergooding linked:
Unhandled` Exception: System.ArgumentException: file not found: D:\j\workspace\x64_checked_w---02832afb\tests\\..\bin\tests\Windws_NT.x64.Checked\\readytorun\DynamicMethodGCStress - note the "Windws". This makes me think we're hitting dotnet/msbuild#2530.

Not going to try to fix this today, but feel free to assign it to me and I'll take a look tomorrow.