Tests in System.Data.Common crash on uapaot

[alexperovich]

The following tests crash on uapaot:

• System.Data.Tests.SqlTypes.SqlXmlTest.Constructor2_Stream_Unicode
• System.Data.Tests.SqlTypes.SqlXmlTest.Constructor2_Stream_Empty
• System.Data.Tests.SqlTypes.SqlXmlTest.Constructor3
• System.Data.Tests.SqlTypes.SqlXmlTest.Constructor3_XmlReader_Empty
• System.Data.Tests.SqlTypes.SqlXmlTest.CreateReader_Stream_Unicode
• System.Data.Tests.SqlTypes.SqlXmlTest.SqlXml_fromXmlReader_CreateReaderTest
• System.Data.Tests.SqlTypes.SqlXmlTest.SqlXml_fromZeroLengthStream_CreateReaderTest
• System.Data.Tests.SqlTypes.SqlXmlTest.SqlXml_fromZeroLengthXmlReader_CreateReaderTest_withFragment

[sjoerdverweij]

I can fix SqlDateTimeTest (not a contributor yet)

[danmoseley]

@sjoerdverweij missed your post. That would be welcome except there is no way for ocmmunity folk to run uapaot tests... perhaps you'd like to make a different contribution?

[saurabh500]

These tests still fail while running with TargetGroup=uapaot

[saurabh500]

So far we have the following findings:

1. The Internal method XmlReader.CreateSqlReader cannot be accessed without modifying the rd.xml file.
   The modifications suggested are

<Assembly Name="System.Private.Xml">
      <Namespace Name="System.Xml">
        <!-- XmlQualifiedName is well known to the serializers and must not be explicitly specified to sg.exe -->
        <Type Name="XmlQualifiedName" DataContractSerializer="Excluded" DataContractJsonSerializer="Excluded"/>               
                <Type Name="XmlReader" Dynamic="Required" />
      </Namespace>

Add this to System.Private.Xml.csproj
<BlockReflectionAttribute>false</BlockReflectionAttribute>

2. Make the method public and make System.Data.Common depend on System.Private.Xml to access the public method instead of accessing the method via reflection.

[safern]

@saurabh500 could you please take a look and fix this?

[saurabh500]

@safern are you talking about reverting the PR which enable this test or a real fix?
I am working with different folks to get a fix in.

I am stuck at figuring out how to make System.Data.COmmon build with System.Private.Xml instead of the System.Xml.ReaderWriter. Any clues?

[safern]

I'm talking about a real fix. Will not revert the PR as the DateTimeTest seems to be fixed. I'm just confirming locally.

I am stuck at figuring out how to make System.Data.COmmon build with System.Private.Xml instead of the System.Xml.ReaderWriter. Any clues?

Not that come to my mind now but @joperezr might know.

[safern]

System.Data.Tests.SqlTypes.SqlDateTimeTest.GetTypeTest is indeed fixed. I don't see it failing anymore. Updating the issue description