-
Notifications
You must be signed in to change notification settings - Fork 5.2k
Closed
Closed
Copy link
Labels
Milestone
Description
In this PR: #52235 there were a couple of non-urgent issues that we can address separately from that PR:
-
- Fix: FileSystemEntry.Attributes property is not correct on Unix #52235 (comment) Use
StartsWith
instead of a manual check of length+first char, when checking if a filename is hidden because it starts with a dot. This method is only reached when the user explicitly checks the hidden value of a file/folder, but not on the most common enumeration scenarios.
- Fix: FileSystemEntry.Attributes property is not correct on Unix #52235 (comment) Use
-
- Fix: FileSystemEntry.Attributes property is not correct on Unix #52235 (comment) When verifying the value of the read-only flag of a file/folder, we always check the values of
GetEUid
andGetEGid
, which are p/invokes. The cases where these are accessed do not have a direct impact in the most common enumeration scenarios, but it would be nice to cache them and make sure their values get refreshed if the user requests doing so, or the file cache is uninitialized.
- Fix: FileSystemEntry.Attributes property is not correct on Unix #52235 (comment) When verifying the value of the read-only flag of a file/folder, we always check the values of
-
- Fix: FileSystemEntry.Attributes property is not correct on Unix #52235 (comment) In
FileSystemEntry.Initialize
, make sure to put the check forsymlink
in anelse if
instead of anif
, since having either unknown or symlink are mutually exclusive cases.
- Fix: FileSystemEntry.Attributes property is not correct on Unix #52235 (comment) In
-
- Fix: FileSystemEntry.Attributes property is not correct on Unix #52235 (comment) Consider reusing
IsNameHidden
when checking for the dot inFileSystemEntry.Initialize
. AROS<char>
needs to be created from thebyte*
, and we need to check if aggressive inlining could help with any potential perf hit from calling two new methods.
- Fix: FileSystemEntry.Attributes property is not correct on Unix #52235 (comment) Consider reusing
-
- Fix: FileSystemEntry.Attributes property is not correct on Unix #52235 (comment) Use the existing property to check if it's a symlink.
-
- Fix: FileSystemEntry.Attributes property is not correct on Unix #52235 (comment) No need to check again for symlink when looking for attributes to skip.
-
- HasNameHidden needs to be checked before EnsureCachesInitialized, inside IsHidden;.
-
- Need to add a new OSX only file to check for UF_HIDDEN, since this does not apply to Unix.
-
- Add perf benchmarks that consume AttributesToSkip.
Edit. I followed up in the same PR.