Skip to content

[HTTP/3] IncompleteResponseStream_ResponseDropped_CancelsRequestToServer test fails #53089

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ManickaP opened this issue May 21, 2021 · 7 comments · Fixed by #58024
Closed

[HTTP/3] IncompleteResponseStream_ResponseDropped_CancelsRequestToServer test fails #53089

ManickaP opened this issue May 21, 2021 · 7 comments · Fixed by #58024
Assignees
@CarnaViire
Labels
area-System.Net.Http disabled-test The test is disabled in source code against the issue
Milestone
7.0.0

Comments

@ManickaP
Copy link
Member

ManickaP commented May 21, 2021 •
edited
Loading

System.Net.Http.Functional.Tests.SocketsHttpHandler_HttpClientHandler_Finalization_Http3_MsQuic.IncompleteResponseStream_ResponseDropped_CancelsRequestToServer" type="System.Net.Http.Functional.Tests.SocketsHttpHandler_HttpClientHandler_Finalization_Http3_MsQuic

Intermittently fails with:

System.Net.Http.HttpRequestException : An error occurred while sending the request.\n---- System.Net.Quic.QuicStreamAbortedException : Stream aborted by peer (0).
   at System.Net.Http.Http3RequestStream.SendAsync(CancellationToken cancellationToken) in /home/manicka/Repositories/runtime/src/libraries/System.Net.Http/src/System/Net/Http/SocketsHttpHandler/Http3RequestStream.cs:line 250
   at System.Net.Http.Http3RequestStream.SendAsync(CancellationToken cancellationToken) in /home/manicka/Repositories/runtime/src/libraries/System.Net.Http/src/System/Net/Http/SocketsHttpHandler/Http3RequestStream.cs:line 296
   at System.Net.Http.Http3Connection.SendAsync(HttpRequestMessage request, Boolean async, CancellationToken cancellationToken) in /home/manicka/Repositories/runtime/src/libraries/System.Net.Http/src/System/Net/Http/SocketsHttpHandler/Http3Connection.cs:line 223
   at System.Net.Http.HttpConnectionPool.TrySendUsingHttp3Async(HttpRequestMessage request, Boolean async, Boolean doRequestAuth, CancellationToken cancellationToken) in /home/manicka/Repositories/runtime/src/libraries/System.Net.Http/src/System/Net/Http/SocketsHttpHandler/HttpConnectionPool.cs:line 800
   at System.Net.Http.HttpConnectionPool.DetermineVersionAndSendAsync(HttpRequestMessage request, Boolean async, Boolean doRequestAuth, CancellationToken cancellationToken) in /home/manicka/Repositories/runtime/src/libraries/System.Net.Http/src/System/Net/Http/SocketsHttpHandler/HttpConnectionPool.cs:line 876
   at System.Net.Http.HttpConnectionPool.SendAndProcessAltSvcAsync(HttpRequestMessage request, Boolean async, Boolean doRequestAuth, CancellationToken cancellationToken) in /home/manicka/Repositories/runtime/src/libraries/System.Net.Http/src/System/Net/Http/SocketsHttpHandler/HttpConnectionPool.cs:line 906
   at System.Net.Http.HttpConnectionPool.SendWithRetryAsync(HttpRequestMessage request, Boolean async, Boolean doRequestAuth, CancellationToken cancellationToken) in /home/manicka/Repositories/runtime/src/libraries/System.Net.Http/src/System/Net/Http/SocketsHttpHandler/HttpConnectionPool.cs:line 925
   at System.Net.Http.RedirectHandler.SendAsync(HttpRequestMessage request, Boolean async, CancellationToken cancellationToken) in /home/manicka/Repositories/runtime/src/libraries/System.Net.Http/src/System/Net/Http/SocketsHttpHandler/RedirectHandler.cs:line 30
   at System.Net.Http.HttpClient.GetStreamAsyncCore(HttpRequestMessage request, CancellationToken cancellationToken) in /home/manicka/Repositories/runtime/src/libraries/System.Net.Http/src/System/Net/Http/HttpClient.cs:line 333
   at System.Net.Http.Functional.Tests.HttpClientHandler_Finalization_Test.<>c__DisplayClass1_0.<<GetAndDropResponse>b__0>d.MoveNext() in /home/manicka/Repositories/runtime/src/libraries/System.Net.Http/tests/FunctionalTests/HttpClientHandlerTest.Finalization.cs:line 23
--- End of stack trace from previous location ---
   at System.Net.Http.Functional.Tests.HttpClientHandler_Finalization_Test.<>c__DisplayClass2_1.<<IncompleteResponseStream_ResponseDropped_CancelsRequestToServer>b__0>d.MoveNext() in /home/manicka/Repositories/runtime/src/libraries/System.Net.Http/tests/FunctionalTests/HttpClientHandlerTest.Finalization.cs:line 35
--- End of stack trace from previous location ---
   at System.Threading.Tasks.TaskTimeoutExtensions.WhenAllOrAnyFailed(Task[] tasks) in /home/manicka/Repositories/runtime/src/libraries/Common/tests/System/Threading/Tasks/TaskTimeoutExtensions.cs:line 63
   at System.Threading.Tasks.TaskTimeoutExtensions.WhenAllOrAnyFailed(Task[] tasks) in /home/manicka/Repositories/runtime/src/libraries/Common/tests/System/Threading/Tasks/TaskTimeoutExtensions.cs:line 82
   at System.Net.Test.Common.LoopbackServerFactory.<>c__DisplayClass5_0.<<CreateClientAndServerAsync>b__0>d.MoveNext() in /home/manicka/Repositories/runtime/src/libraries/Common/tests/System/Net/Http/GenericLoopbackServer.cs:line 36
--- End of stack trace from previous location ---
   at System.Net.Test.Common.Http3LoopbackServerFactory.CreateServerAsync(Func`3 funcAsync, Int32 millisecondsTimeout, GenericLoopbackOptions options) in /home/manicka/Repositories/runtime/src/libraries/Common/tests/System/Net/Http/Http3LoopbackServer.cs:line 97
   at System.Net.Http.Functional.Tests.HttpClientHandler_Finalization_Test.IncompleteResponseStream_ResponseDropped_CancelsRequestToServer() in /home/manicka/Repositories/runtime/src/libraries/System.Net.Http/tests/FunctionalTests/HttpClientHandlerTest.Finalization.cs:line 33
--- End of stack trace from previous location ---
----- Inner Stack Trace -----
   at System.Net.Quic.Implementations.MsQuic.MsQuicStream.HandleEventPeerSendAborted(State state, StreamEvent& evt) in /home/manicka/Repositories/runtime/src/libraries/System.Net.Quic/src/System/Net/Quic/Implementations/MsQuic/MsQuicStream.cs:line 748
   at System.Net.Quic.Implementations.MsQuic.MsQuicStream.HandleEvent(State state, StreamEvent& evt) in /home/manicka/Repositories/runtime/src/libraries/System.Net.Quic/src/System/Net/Quic/Implementations/MsQuic/MsQuicStream.cs:line 574
   at System.Net.Quic.Implementations.MsQuic.MsQuicStream.NativeCallbackHandler(IntPtr stream, IntPtr context, StreamEvent& streamEvent) in /home/manicka/Repositories/runtime/src/libraries/System.Net.Quic/src/System/Net/Quic/Implementations/MsQuic/MsQuicStream.cs:line 544
--- End of stack trace from previous location ---
   at System.Net.Quic.Implementations.MsQuic.Internal.ResettableCompletionSource`1.GetResult(Int16 token) in /home/manicka/Repositories/runtime/src/libraries/System.Net.Quic/src/System/Net/Quic/Implementations/MsQuic/Internal/ResettableCompletionSource.cs:line 57
   at System.Net.Quic.Implementations.MsQuic.MsQuicStream.ReadAsync(Memory`1 destination, CancellationToken cancellationToken) in /home/manicka/Repositories/runtime/src/libraries/System.Net.Quic/src/System/Net/Quic/Implementations/MsQuic/MsQuicStream.cs:line 318
   at System.Net.Http.Http3RequestStream.ReadFrameEnvelopeAsync(CancellationToken cancellationToken) in /home/manicka/Repositories/runtime/src/libraries/System.Net.Http/src/System/Net/Http/SocketsHttpHandler/Http3RequestStream.cs:line 723
   at System.Net.Http.Http3RequestStream.ReadResponseAsync(CancellationToken cancellationToken) in /home/manicka/Repositories/runtime/src/libraries/System.Net.Http/src/System/Net/Http/SocketsHttpHandler/Http3RequestStream.cs:line 309
   at System.Net.Http.Http3RequestStream.SendAsync(CancellationToken cancellationToken) in /home/manicka/Repositories/runtime/src/libraries/System.Net.Http/src/System/Net/Http/SocketsHttpHandler/Http3RequestStream.cs:line 199
@ManickaP ManickaP added area-System.Net.Http disabled-test The test is disabled in source code against the issue labels May 21, 2021
@ManickaP ManickaP added this to the 6.0.0 milestone May 21, 2021
@ghost ghost added the untriaged New issue has not been triaged by the area owner label May 21, 2021
@ghost
Copy link

ghost commented May 21, 2021

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

System.Net.Http.Functional.Tests.SocketsHttpHandler_HttpClientHandler_Finalization_Http3_MsQuic.IncompleteResponseStream_ResponseDropped_CancelsRequestToServer" type="System.Net.Http.Functional.Tests.SocketsHttpHandler_HttpClientHandler_Finalization_Http3_MsQuic

Fails with:

System.Net.Http.HttpRequestException : An error occurred while sending the request.\n---- System.Net.Quic.QuicStreamAbortedException : Stream aborted by peer (0).
   at System.Net.Http.Http3RequestStream.SendAsync(CancellationToken cancellationToken) in /home/manicka/Repositories/runtime/src/libraries/System.Net.Http/src/System/Net/Http/SocketsHttpHandler/Http3RequestStream.cs:line 250
   at System.Net.Http.Http3RequestStream.SendAsync(CancellationToken cancellationToken) in /home/manicka/Repositories/runtime/src/libraries/System.Net.Http/src/System/Net/Http/SocketsHttpHandler/Http3RequestStream.cs:line 296
   at System.Net.Http.Http3Connection.SendAsync(HttpRequestMessage request, Boolean async, CancellationToken cancellationToken) in /home/manicka/Repositories/runtime/src/libraries/System.Net.Http/src/System/Net/Http/SocketsHttpHandler/Http3Connection.cs:line 223
   at System.Net.Http.HttpConnectionPool.TrySendUsingHttp3Async(HttpRequestMessage request, Boolean async, Boolean doRequestAuth, CancellationToken cancellationToken) in /home/manicka/Repositories/runtime/src/libraries/System.Net.Http/src/System/Net/Http/SocketsHttpHandler/HttpConnectionPool.cs:line 800
   at System.Net.Http.HttpConnectionPool.DetermineVersionAndSendAsync(HttpRequestMessage request, Boolean async, Boolean doRequestAuth, CancellationToken cancellationToken) in /home/manicka/Repositories/runtime/src/libraries/System.Net.Http/src/System/Net/Http/SocketsHttpHandler/HttpConnectionPool.cs:line 876
   at System.Net.Http.HttpConnectionPool.SendAndProcessAltSvcAsync(HttpRequestMessage request, Boolean async, Boolean doRequestAuth, CancellationToken cancellationToken) in /home/manicka/Repositories/runtime/src/libraries/System.Net.Http/src/System/Net/Http/SocketsHttpHandler/HttpConnectionPool.cs:line 906
   at System.Net.Http.HttpConnectionPool.SendWithRetryAsync(HttpRequestMessage request, Boolean async, Boolean doRequestAuth, CancellationToken cancellationToken) in /home/manicka/Repositories/runtime/src/libraries/System.Net.Http/src/System/Net/Http/SocketsHttpHandler/HttpConnectionPool.cs:line 925
   at System.Net.Http.RedirectHandler.SendAsync(HttpRequestMessage request, Boolean async, CancellationToken cancellationToken) in /home/manicka/Repositories/runtime/src/libraries/System.Net.Http/src/System/Net/Http/SocketsHttpHandler/RedirectHandler.cs:line 30
   at System.Net.Http.HttpClient.GetStreamAsyncCore(HttpRequestMessage request, CancellationToken cancellationToken) in /home/manicka/Repositories/runtime/src/libraries/System.Net.Http/src/System/Net/Http/HttpClient.cs:line 333
   at System.Net.Http.Functional.Tests.HttpClientHandler_Finalization_Test.<>c__DisplayClass1_0.<<GetAndDropResponse>b__0>d.MoveNext() in /home/manicka/Repositories/runtime/src/libraries/System.Net.Http/tests/FunctionalTests/HttpClientHandlerTest.Finalization.cs:line 23
--- End of stack trace from previous location ---
   at System.Net.Http.Functional.Tests.HttpClientHandler_Finalization_Test.<>c__DisplayClass2_1.<<IncompleteResponseStream_ResponseDropped_CancelsRequestToServer>b__0>d.MoveNext() in /home/manicka/Repositories/runtime/src/libraries/System.Net.Http/tests/FunctionalTests/HttpClientHandlerTest.Finalization.cs:line 35
--- End of stack trace from previous location ---
   at System.Threading.Tasks.TaskTimeoutExtensions.WhenAllOrAnyFailed(Task[] tasks) in /home/manicka/Repositories/runtime/src/libraries/Common/tests/System/Threading/Tasks/TaskTimeoutExtensions.cs:line 63
   at System.Threading.Tasks.TaskTimeoutExtensions.WhenAllOrAnyFailed(Task[] tasks) in /home/manicka/Repositories/runtime/src/libraries/Common/tests/System/Threading/Tasks/TaskTimeoutExtensions.cs:line 82
   at System.Net.Test.Common.LoopbackServerFactory.<>c__DisplayClass5_0.<<CreateClientAndServerAsync>b__0>d.MoveNext() in /home/manicka/Repositories/runtime/src/libraries/Common/tests/System/Net/Http/GenericLoopbackServer.cs:line 36
--- End of stack trace from previous location ---
   at System.Net.Test.Common.Http3LoopbackServerFactory.CreateServerAsync(Func`3 funcAsync, Int32 millisecondsTimeout, GenericLoopbackOptions options) in /home/manicka/Repositories/runtime/src/libraries/Common/tests/System/Net/Http/Http3LoopbackServer.cs:line 97
   at System.Net.Http.Functional.Tests.HttpClientHandler_Finalization_Test.IncompleteResponseStream_ResponseDropped_CancelsRequestToServer() in /home/manicka/Repositories/runtime/src/libraries/System.Net.Http/tests/FunctionalTests/HttpClientHandlerTest.Finalization.cs:line 33
--- End of stack trace from previous location ---
----- Inner Stack Trace -----
   at System.Net.Quic.Implementations.MsQuic.MsQuicStream.HandleEventPeerSendAborted(State state, StreamEvent& evt) in /home/manicka/Repositories/runtime/src/libraries/System.Net.Quic/src/System/Net/Quic/Implementations/MsQuic/MsQuicStream.cs:line 748
   at System.Net.Quic.Implementations.MsQuic.MsQuicStream.HandleEvent(State state, StreamEvent& evt) in /home/manicka/Repositories/runtime/src/libraries/System.Net.Quic/src/System/Net/Quic/Implementations/MsQuic/MsQuicStream.cs:line 574
   at System.Net.Quic.Implementations.MsQuic.MsQuicStream.NativeCallbackHandler(IntPtr stream, IntPtr context, StreamEvent& streamEvent) in /home/manicka/Repositories/runtime/src/libraries/System.Net.Quic/src/System/Net/Quic/Implementations/MsQuic/MsQuicStream.cs:line 544
--- End of stack trace from previous location ---
   at System.Net.Quic.Implementations.MsQuic.Internal.ResettableCompletionSource`1.GetResult(Int16 token) in /home/manicka/Repositories/runtime/src/libraries/System.Net.Quic/src/System/Net/Quic/Implementations/MsQuic/Internal/ResettableCompletionSource.cs:line 57
   at System.Net.Quic.Implementations.MsQuic.MsQuicStream.ReadAsync(Memory`1 destination, CancellationToken cancellationToken) in /home/manicka/Repositories/runtime/src/libraries/System.Net.Quic/src/System/Net/Quic/Implementations/MsQuic/MsQuicStream.cs:line 318
   at System.Net.Http.Http3RequestStream.ReadFrameEnvelopeAsync(CancellationToken cancellationToken) in /home/manicka/Repositories/runtime/src/libraries/System.Net.Http/src/System/Net/Http/SocketsHttpHandler/Http3RequestStream.cs:line 723
   at System.Net.Http.Http3RequestStream.ReadResponseAsync(CancellationToken cancellationToken) in /home/manicka/Repositories/runtime/src/libraries/System.Net.Http/src/System/Net/Http/SocketsHttpHandler/Http3RequestStream.cs:line 309
   at System.Net.Http.Http3RequestStream.SendAsync(CancellationToken cancellationToken) in /home/manicka/Repositories/runtime/src/libraries/System.Net.Http/src/System/Net/Http/SocketsHttpHandler/Http3RequestStream.cs:line 199
Author: ManickaP
Assignees: -
Labels:

area-System.Net.Http, disabled-test
Milestone: 6.0.0

@ManickaP ManickaP removed the untriaged New issue has not been triaged by the area owner label May 21, 2021
@ManickaP ManickaP mentioned this issue May 21, 2021
Merged
@ManickaP ManickaP modified the milestones: 6.0.0, Future Aug 10, 2021
@CarnaViire CarnaViire self-assigned this Aug 23, 2021
@CarnaViire CarnaViire mentioned this issue Aug 24, 2021
Merged
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Aug 24, 2021
CarnaViire added a commit that referenced this issue Aug 24, 2021
@CarnaViire
Enable IncompleteResponseStream_ResponseDropped_CancelsRequestToServe…
c1c90d3 
…r for H/3 (#58024)

Fixes #53089
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Aug 24, 2021
@karelz karelz modified the milestones: Future, 7.0.0 Aug 26, 2021
@geoffkizer
Copy link
Contributor

While this test is not failing anymore, it's still not working properly. See comments here: #58234

@geoffkizer geoffkizer reopened this Aug 27, 2021
@karelz karelz removed the disabled-test The test is disabled in source code against the issue label Aug 27, 2021
@karelz
Copy link
Member

karelz commented Aug 27, 2021

@geoffkizer does it mean it still fails intermittently with this specific callstack? Or is it different problem with the test?

@geoffkizer
Copy link
Contributor

Right now it is not failing at all, but it's not working as intended.
With this PR it hangs: #58088
So I've disabled it as part of that PR.
We should make it work as intended before re-enabling it. See #58234.

@geoffkizer
Copy link
Contributor

We can close this and just track via #58234, if that's better. That issue tracks the underlying problem here.

@karelz
Copy link
Member

karelz commented Aug 27, 2021

Yeah, I would close and track with the other issue -- once you merge your PR disabling the test, let's not forget to add disabled-test label to it.

@ManickaP ManickaP added the disabled-test The test is disabled in source code against the issue label Aug 27, 2021
@ManickaP
Copy link
Member Author

Putting back into closed state since we track the the disabled test in #58234.

ManickaP pushed a commit that referenced this issue Sep 2, 2021
@CarnaViire @ManickaP
Enable IncompleteResponseStream_ResponseDropped_CancelsRequestToServe…
e1997ef 
…r for H/3 (#58024)

Fixes #53089
@ghost ghost locked as resolved and limited conversation to collaborators Sep 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@CarnaViire CarnaViire

Labels
area-System.Net.Http disabled-test The test is disabled in source code against the issue
Projects
None yet
Milestone
7.0.0
Development

Successfully merging a pull request may close this issue.

[HTTP/3] Enable IncompleteResponseStream_ResponseDropped_CancelsRequestToServer CarnaViire/runtime
4 participants
@CarnaViire @karelz @ManickaP @geoffkizer