[wasm] System.Net.Http.BrowserHttpHandler.SendAsync() throws NRE

[pavelsavara]

In unit test System.Net.Http.Functional.Tests.HttpClientHandler_RemoteServerTest.GetAsync_RequestHeadersAddCustomHeaders_HeaderAndEmptyValueSent(remoteServer: (BaseUri: https://127.0.0.1:61813/, HttpVersion: 1.1) on WASM and browser.

System.NullReferenceException : Object reference not set to an instance of an object.
   at System.Net.Http.BrowserHttpHandler.SendAsync(HttpRequestMessage request, CancellationToken cancellationToken)
   at System.Net.Http.HttpClient.<SendAsync>g__Core|83_0(HttpRequestMessage request, HttpCompletionOption completionOption, CancellationTokenSource cts, Boolean disposeCts, CancellationTokenSource pendingRequestsCts, CancellationToken originalCancellationToken)
   at System.Net.Http.Functional.Tests.HttpClientHandler_RemoteServerTest.GetAsync_RequestHeadersAddCustomHeaders_HeaderAndEmptyValueSent(RemoteServer remoteServer, Uri uri)

This is not network related issue, it could be reproduced without BrowserHttpHandler see https://github.com/dotnet/runtime/pull/54453/files

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

---

In unit test System.Net.Http.Functional.Tests.HttpClientHandler_RemoteServerTest.GetAsync_RequestHeadersAddCustomHeaders_HeaderAndEmptyValueSent(remoteServer: (BaseUri: https://127.0.0.1:61813/, HttpVersion: 1.1) on WASM and browser.

System.NullReferenceException : Object reference not set to an instance of an object.
   at System.Net.Http.BrowserHttpHandler.SendAsync(HttpRequestMessage request, CancellationToken cancellationToken)
   at System.Net.Http.HttpClient.<SendAsync>g__Core|83_0(HttpRequestMessage request, HttpCompletionOption completionOption, CancellationTokenSource cts, Boolean disposeCts, CancellationTokenSource pendingRequestsCts, CancellationToken originalCancellationToken)
   at System.Net.Http.Functional.Tests.HttpClientHandler_RemoteServerTest.GetAsync_RequestHeadersAddCustomHeaders_HeaderAndEmptyValueSent(RemoteServer remoteServer, Uri uri)

Author:	pavelsavara
Assignees:	-
Labels:	arch-wasm, area-System.Net.Http
Milestone:	-

[lewing]

Looking at the test I don't see an obvious reason it should fail like this. Is this failing on all browser lanes? There was some work done allow trimming more of the header logic out and if these tests weren't running they may have regressed.

[pavelsavara]

Here is example of the failure on CI
https://helixre8s23ayyeko0k025g8.blob.core.windows.net/dotnet-runtime-refs-pull-53925-merge-160a064b73f24741b2/System.Net.Http.Functional.Tests/console.3a6c0e9f.log?sv=2019-07-07&se=2021-06-30T09%3A14%3A59Z&sr=c&sp=rl&sig=qBO1wWtqkq9AGYRX0b82P6An%2BBE0LKFnuckJY0ed6BU%3D

This time different test and on ubuntu, not windows.
System.Net.Http.Functional.Tests.HttpClientHandler_RemoteServerTest.GetAsync_ServerNeedsAuthAndNoCredential_StatusCodeUnauthorized

Maybe race condition ?

[pavelsavara]

Yes second CI run on the same code as above is green.

[pavelsavara]

Another locally

System.Net.Http.Functional.Tests.HttpClientHandler_RemoteServerTest.GetAsync_RequestHeadersAddCustomHeaders_HeaderAndValueSent(remoteServer: (BaseUri: https://127.0.0.1:57664/, HttpVersion: 1.1), name: "X-CustomHeader", value: "x-value", uri: https://127.0.0.1:57664/Echo.ashx)
  info: System.NullReferenceException : Object reference not set to an instance of an object.
  info:    at System.Net.Http.BrowserHttpHandler.SendAsync(HttpRequestMessage request, CancellationToken cancellationToken)
  info:    at System.Net.Http.HttpClient.<SendAsync>g__Core|83_0(HttpRequestMessage request, HttpCompletionOption completionOption, CancellationTokenSource cts, Boolean disposeCts, CancellationTokenSource pendingRequestsCts, CancellationToken originalCancellationToken)
  info:    at System.Net.Http.Functional.Tests.HttpClientHandler_RemoteServerTest.GetAsync_RequestHeadersAddCustomHeaders_HeaderAndValueSent(RemoteServer remoteServer, String name, String value, Uri uri)