Microsoft.Extensions.Logging solution can't be built from Visual Studio

[Sundow]

Description

Open the solution Microsoft.Extensions.Logging in Visual Studio by executing
\build.cmd -vs Microsoft.Extensions.Logging

Try to build/rebuild the whole solution. Build fails with the following errors:

...\runtime\src\libraries\Microsoft.Extensions.Logging.Abstractions\gen\Microsoft.Extensions.Logging.Generators.csproj : error MSB4057: The target "GetTargetPath" does not exist in the project.

...\runtime\src\libraries\System.Text.Json\gen\System.Text.Json.SourceGeneration.csproj : error MSB4057: The target "GetTargetPath" does not exist in the project.

Building from a command line works ok. But this issue makes it impossible to work with unit tests in VS as they can't be built and executed.

Regression?

Microsoft.Extensions.Logging.Generators.csproj and System.Text.Json.SourceGeneration.csproj were added relatively recently. The problem didn't exist before.

Tagging subscribers to this area: @Anipik, @safern, @ViktorHofer
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Description

Open the solution Microsoft.Extensions.Logging in Visual Studio by executing
\build.cmd -vs Microsoft.Extensions.Logging

Try to build/rebuild the whole solution. Build fails with the following errors:

...\runtime\src\libraries\Microsoft.Extensions.Logging.Abstractions\gen\Microsoft.Extensions.Logging.Generators.csproj : error MSB4057: The target "GetTargetPath" does not exist in the project.

...\runtime\src\libraries\System.Text.Json\gen\System.Text.Json.SourceGeneration.csproj : error MSB4057: The target "GetTargetPath" does not exist in the project.

Building from a command line works ok. But this issue makes it impossible to work with unit tests in VS as they can't be built and executed.

Regression?

Microsoft.Extensions.Logging.Generators.csproj and System.Text.Json.SourceGeneration.csproj were added relatively recently. The problem didn't exist before.

Author:	Sundow
Assignees:	-
Labels:	area-Infrastructure-libraries, untriaged
Milestone:	-

[ViktorHofer]

Could be related to a recent infra change that I merged yesterday. Will take a look.

[Sundow]

Could be related to a recent infra change that I merged yesterday. Will take a look.

The issue exists for some time, it is definitely older than yesterday. My impression is that when these 2 generator projects were added VS solution behavior was not tested. I fixed a path in a solution file (see #53434) but looks like there is more than that.

[eerhardt]

@ViktorHofer @layomia - any update on this? I am seeing it in CI:

https://github.com/dotnet/runtime/pull/56753/checks?check_run_id=3230171324

https://dev.azure.com/dnceng/public/_build/results?buildId=1272222&view=logs&j=81a0f8c2-d4db-561f-9b8e-3f045280d7fe&t=2a104984-c43b-5b93-1361-6bd8a1e96b04&l=2270

  Microsoft.Extensions.Http -> D:\workspace\_work\1\s\artifacts\bin\Microsoft.Extensions.Http\net461-Debug\Microsoft.Extensions.Http.dll
D:\workspace\_work\1\s\src\libraries\System.Text.Json\gen\System.Text.Json.SourceGeneration.csproj : error MSB4057: The target "GetTargetPath" does not exist in the project.
##[error]src\libraries\System.Text.Json\gen\System.Text.Json.SourceGeneration.csproj(0,0): error MSB4057: The target "GetTargetPath" does not exist in the project.

[safern]

@eerhardt I fixed the CI issue yesterday on: #56767

I don't think the VS issue is cause by this as it has been happening int since a long time ago.

[ViktorHofer]

That was an issue during the conversion from pkgproj to csproj and got fixed. The GetTargetPath msbuild target was called from the wrong build dimension. Don't remember the commit anymore but am sure that this specific issue is fixed.