[QUIC] Erroneous flow of inbound MsQuicStream ctor doesn't release safe handle

[ManickaP]

Source: Coder review session

runtime/src/libraries/System.Net.Quic/src/System/Net/Quic/Implementations/MsQuic/MsQuicStream.cs

Lines 114 to 118 in f59a132

	catch
	{
	_state.StateGCHandle.Free();
	throw;
	}

See ctor for outbound, it does release it.

It should not matter that we're doing it on msquic thread.

Alternative: Return a specific error code in MsQuicConnection to clean the handle for us.

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

---

runtime/src/libraries/System.Net.Quic/src/System/Net/Quic/Implementations/MsQuic/MsQuicStream.cs

Lines 114 to 118 in f59a132

	catch
	{
	_state.StateGCHandle.Free();
	throw;
	}

See ctor for outbound, it does release it.

It should not matter that we're doing it on msquic thread.

Author:	ManickaP
Assignees:	-
Labels:	area-System.Net.Quic, untriaged
Milestone:	-

[rzikm]

I think the code is correct as-is. When exception is thrown (when does it actually happen?), then the NativeCallbackHandler returns MsQuicStatusCodes.InternalError, which will cause MsQuic to release the Stream on its own. Thoughts? @ManickaP

[ManickaP]

Based on what do you think msquic will release the handle if we return error code from NEW_STREAM event? Have you found it somewhere in msquic docs/code?

[rzikm]

I have checked the source code: https://github.com/microsoft/msquic/blob/main/src/core/stream_set.c#L684-L693
Same for v 1.9

[ManickaP]

You're right, it's the same behavior as with new incoming connection on a listener, but it's not documented anywhere in msquic.
Let's close this then.