-
Notifications
You must be signed in to change notification settings - Fork 5.2k
Closed
Labels
area-Tools-ILVerificationIssues related to ilverify tool and IL verification in generalIssues related to ilverify tool and IL verification in generaluntriagedNew issue has not been triaged by the area ownerNew issue has not been triaged by the area owner
Description
The .NET source-build tarball is failing to build on release/6.0.3xx with the following error:
/tarball/src/runtime.3a25a7f1cc446b60678ed25c9d829420d6321eba/artifacts/source-build/self/src/src/coreclr/tools/ILVerify/Program.cs(498,31): error CS0103: The name 'CommandHandler' does not exist in the current context [/tarball/src/runtime.3a25a7f1cc446b60678ed25c9d829420d6321eba/artifacts/source-build/self/src/src/coreclr/tools/ILVerify/ILVerify.csproj]
This stems from a couple of factors.
- Source build only builds one version of each repo. The sdk's dependency on dotnet/command-line-api is the version included in source-build.
- dotnet/command-line-api made some breaking changes and the dotnet/sdk took a dependency on the latest release while dotnet/runtime is on an older version.
Updating dotnet/runtime's version of command-line-api to the same as the sdk will solve the problem for release/6.0.3xx but it will then break release/6.0.2xx and release/6.0.1xx which are on the older version. Upgrading the sdk to the latest command-line-api is a significant amount of work and was rejected to 6.0.2xx.
Options to fix this issue.
- Exclude ILVerify from source-build. I took a cursory look and see that ILVerification.nupkg is required but ILVerify might not be needed.
- Update ILVerify to be conditioned so that it could build with either version (beta1 or beta2) of command-line-api.
- Build both command-line-api versions in source-build. This is a new feature which feels too for a servicing release. It should only be a last resort after exhausting all other options.
cc @dotnet/source-build-internal
Metadata
Metadata
Assignees
Labels
area-Tools-ILVerificationIssues related to ilverify tool and IL verification in generalIssues related to ilverify tool and IL verification in generaluntriagedNew issue has not been triaged by the area ownerNew issue has not been triaged by the area owner