[browser][mt] TCValidateAfterAddInvalidSchema.AddValid_Import_Include_Redefine

[simonrozsival]

The test fails processing the schB8.xsd input file. This input differs from the other test inputs by including a schema with a HTTP location:

<xsd:include schemaLocation="http://foo/foo" />

This is likely related to #75123

Ref #74407

It's a timeout, test hangs and does not throw.
Stack trace collected in the investigation:

[InlineData("SCHEMA", "schB8.xsd", 1, 1, 1)]
AddValid_Import_Include_Redefine(string testDir, string testFile, int expCount, int expCountGT, int expCountGE)
-> ss.Add(Schema);
XmlSchemaSet.Add(XmlSchema schema)
-> return Add(schema.TargetNamespace, schema);
XmlSchemaSet.Add(string? targetNamespace, XmlReader schemaDocument) // - I cannot catch the test fail with this line commented out

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

---

The test fails processing the schB8.xsd input file. This input differs from the other test inputs by including a schema with a HTTP location:

<xsd:include schemaLocation="http://foo/foo" />

This is likely related to #75123

Ref #74407

Author:	simonrozsival
Assignees:	-
Labels:	arch-wasm, disabled-test, area-Build-mono
Milestone:	-

[pavelsavara]

stack trace would help, @ilonatommy could you please try to reproduce this ?

[ilonatommy]

I know what the fix could be but I don't know how to do it neatly. We are using s_defaultReaderSettings here

runtime/src/libraries/System.Private.Xml/src/System/Xml/Core/XmlReaderSettings.cs

Line 15 in ac56247

internal static readonly XmlReaderSettings s_defaultReaderSettings = new() { ReadOnly = true };

that works synchronically. We are able to do e.g.

#if FEATURE_WASM_THREADS
        internal static readonly XmlReaderSettings s_defaultReaderSettings = new() { Async = true }; // what about readOnly?
#else
        internal static readonly XmlReaderSettings s_defaultReaderSettings = new() { ReadOnly = true };
#endif

but as I pointed in the comment: we're doing it with the cost of ReadOnly functionality and I don't think it is an accepted soluton. I will make a PR to discuss it.

[pavelsavara]

In order to make those tests work, we need to have the tested file available in the VFS.
Does this test run/work in ST build ?

[ilonatommy]

Does this test run/work in ST build ?

No, it does not run, it's blocked for browser platform. When enabled, ST has the same stack trace as MT.