Remove pinned xunit.analyzers version

[ViktorHofer]

Arcade promotes the latest xunit which also brings xunit.analyzers in. The current version (as of time of writing) is 1.10.0: https://www.nuget.org/packages/xunit.analyzers

We had to pin the version to 1.4.0 which is the version that runtime currently uses to unblock the dependency flow in #97087.

This issue tracks un-pinning that version and resolving the analyzer warnings.

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Arcade promotes the latest xunit which also brings xunit.analyzers in. The current version (as of time of writing) is 1.10.0: https://www.nuget.org/packages/xunit.analyzers

We had to pin the version to 1.4.0 which is the version that runtime currently uses to unblock the dependency flow in #97087.

This issue tracks un-pinning that version and resolving the analyzer warnings.

Author:	ViktorHofer
Assignees:	-
Labels:	area-Infrastructure
Milestone:	9.0.0