Add JitOptRepeat configuration options #100154
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JitOptRepeat is still off by default. 1. Add a `DOTNET_JitEnableOptRepeat` option. By default this is zero, meaning OptRepeat is disabled. Set it to one to enable JitOptRepeat. Enabling it will allow OptRepeat to kick in during JitStress, but will not otherwise enable it. Also setting `DOTNET_JitOptRepeat` to a method set will enable JitOptRepeat for that exact set of methods. The number of repetitions is specified by `DOTNET_JitOptRepeatCount`. 2. Enable JitOptRepeat to kick in for stress (if `DOTNET_JitEnableOptRepeat` is set to non-zero). The repetition count is set randomly (based on method hash seed) between 2 and 5. 3. Add `DOTNET_JitOptRepeatRange`. This limits JitOptRepeat to a method hash range, for isolating JitOptRepeat related bad codegen.
ghost
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
|
This is extracted from #94250 to make that PR smaller. |
|
@AndyAyersMS PTAL |
BruceForstall
added a commit
to BruceForstall/runtime
that referenced
this pull request
Mar 22, 2024
This includes dotnet#100154, dotnet#100160, dotnet#100123
This was referenced Mar 22, 2024
|
There are asm diffs because there are a few tests that set |
AndyAyersMS
approved these changes
Mar 23, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JitOptRepeat is still off by default.
DOTNET_JitEnableOptRepeatoption. By default this is zero, meaning OptRepeat is disabled. Set it to one to enable JitOptRepeat. Enabling it will allow OptRepeat to kick in during JitStress, but will not otherwise enable it. Also settingDOTNET_JitOptRepeatto a method set will enable JitOptRepeat for that exact set of methods. The number of repetitions is specified byDOTNET_JitOptRepeatCount.DOTNET_JitEnableOptRepeatis set to non-zero). The repetition count is set randomly (based on method hash seed) between 2 and 5.DOTNET_JitOptRepeatRange. This limits JitOptRepeat to a method hash range, for isolating JitOptRepeat related bad codegen.