Only add interface methods to _virtual_methods cache #101139
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We only ever do operations on interface methods, so we can only keep interface methods rather than all virtual methods
ghost
added
the
area-Tools-ILLink
dotnet-policy-service
bot
added
the
linkable-framework
jtschuster
removed
the
linkable-framework
dotnet-policy-service
bot
added
the
linkable-framework
|
Tagging subscribers to this area: @agocke, @sbomer, @vitek-karas |
This was referenced Apr 16, 2024
sbomer
approved these changes
Apr 17, 2024
matouskozak
pushed a commit
to matouskozak/runtime
that referenced
this pull request
Apr 30, 2024
We only ever do operations on interface methods, so we can only keep interface methods rather than all virtual methods
michaelgsharp
pushed a commit
to michaelgsharp/runtime
that referenced
this pull request
May 9, 2024
We only ever do operations on interface methods, so we can only keep interface methods rather than all virtual methods
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We only ever do operations on interface methods, so we can track only interface methods rather than all virtual methods. The decrease in allocations and speed increase are smaller than I expected but look significant.