[cdac] link a stub contract descriptor if cdac-build-tool is not available #101297
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lable Fixes builds that use src/coreclr/build-runtime.sh directly, or bringup scenarios without msbuild
ghost
added
the
Related to dotnet/installer#19534 (comment) Co-Authored-By: Adeel Mujahid <[email protected]>
lambdageek
requested review from
akoeplinger,
am11,
ViktorHofer and
elinor-fung
am11
reviewed
Apr 19, 2024
it's only unset by .NET Framework which is not supported by runtime.proj
lambdageek
added
source-build
elinor-fung
approved these changes
Apr 19, 2024
|
FYI the issue this is fixing is causing all codegen PR formatting legs to fail... |
|
Tagging subscribers to this area: @tommcdon |
I guess this is another use-case for running build-runtime.sh without the managed build stuff. In this case also it looks like using a stub contract is reasonable |
|
CI is green on AzDO. Feel free to merge. |
matouskozak
pushed a commit
to matouskozak/runtime
that referenced
this pull request
Apr 30, 2024
…lable (dotnet#101297) * [cdac] link a stub contract descriptor if cdac-build-tool is not available Fixes builds that use src/coreclr/build-runtime.sh directly, or bringup scenarios without msbuild * Use DOTNET_HOST_PATH to run cdac-build-tool Related to dotnet/installer#19534 (comment) it's only unset by .NET Framework which is not supported by runtime.proj --------- Co-authored-by: Adeel Mujahid <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes builds that use src/coreclr/build-runtime.sh directly, or bringup scenarios without msbuild
Use
DOTNET_HOST_PATHto runcdac-build-toolif it is set. Fixes VMR source builds: dotnet/installer#19534 (comment)Related to #100650 (comment)