Disable TensorPrimitives vectorization of Log, Cbrt, Pow, and RootN #101690
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
Tagging subscribers to this area: @dotnet/area-system-numerics |
...ibraries/System.Numerics.Tensors/src/System/Numerics/Tensors/netcore/TensorPrimitives.Log.cs
Outdated
Show resolved
Hide resolved
We had a test bug that was hiding cases where one of the expected / actual was NaN and the other wasn't.
stephentoub
force-pushed
the
fixequalitynan
branch
from
77c1a00 to
f106038
Compare
This was referenced Apr 29, 2024
|
@tannergooding, mind approving if it looks ok to you? |
tannergooding
approved these changes
Apr 29, 2024
matouskozak
pushed a commit
to matouskozak/runtime
that referenced
this pull request
Apr 30, 2024
…otnet#101690) We had a test bug that was hiding cases where one of the expected / actual was NaN and the other wasn't.
|
Regressions: |
Thanks. This is good to see, actually; shows that the vectorization was beneficial. We just need to make it correct first :) |
|
There were also some possible improvements here: dotnet/perf-autofiling-issues#33927 |
michaelgsharp
pushed a commit
to michaelgsharp/runtime
that referenced
this pull request
May 9, 2024
…otnet#101690) We had a test bug that was hiding cases where one of the expected / actual was NaN and the other wasn't.
Ruihan-Yin
pushed a commit
to Ruihan-Yin/runtime
that referenced
this pull request
May 30, 2024
…otnet#101690) We had a test bug that was hiding cases where one of the expected / actual was NaN and the other wasn't.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had a test bug that was hiding cases where one of the expected / actual was NaN and the other wasn't.
#100535