Skip to content

Don't enable use-after-return checking on Apple's Clang #101781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 3, 2024
Merged

Don't enable use-after-return checking on Apple's Clang #101781

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8fe5738
Don't enable use-after-return checking on Apple's Clang
jkoritzinsky May 1, 2024
70e7878
Update configurecompiler.cmake
jkoritzinsky May 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions eng/native/configurecompiler.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,8 +211,8 @@ if (CLR_CMAKE_ENABLE_SANITIZERS)
# Disable the use-after-return check for ASAN on Clang. This is because we have a lot of code that
# depends on the fact that our locals are not saved in a parallel stack, so we can't enable this today.
# If we ever have a way to detect a parallel stack and track its bounds, we can re-enable this check.
add_compile_options($<$<COMPILE_LANG_AND_ID:C,Clang>:-fsanitize-address-use-after-return=never>)
add_compile_options($<$<COMPILE_LANG_AND_ID:CXX,Clang>:-fsanitize-address-use-after-return=never>)
add_compile_options($<$<COMPILE_LANG_AND_ID:C,Clang,AppleClang>:-fsanitize-address-use-after-return=never>)
add_compile_options($<$<COMPILE_LANG_AND_ID:CXX,Clang,AppleClang>:-fsanitize-address-use-after-return=never>)
endif()
endif()

Expand Down