Skip to content

Fill in FeatureCheckDataflow.cs assertions with issue links #102679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 4, 2024
Merged

Fill in FeatureCheckDataflow.cs assertions with issue links #102679

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3873c08
Add notes for nativeAOT specific issues and fill in FeatureCheckDataf…
jtschuster May 24, 2024
e265b93
Change DoesNotReturn behavior links to reasons
jtschuster May 28, 2024
951d665
Make warnings with reasons instead of issues expected
jtschuster May 29, 2024
4d4d8be
Add issue for boolean operator understanding in ilc and trimmer
jtschuster May 29, 2024
12777dd
Merge branch 'main' of https://github.com/dotnet/runtime into Feature…
jtschuster Jun 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/tools/illink/test/Mono.Linker.Tests.Cases/DataFlow/DynamicObjects.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,7 @@ static void MethodWithRequires ()
}

[ExpectedWarning ("IL2026", nameof (MethodWithRequires))]
[ExpectedWarning ("IL3050", nameof (MethodWithRequires), Tool.Analyzer | Tool.NativeAot, "")]
[ExpectedWarning ("IL3050", nameof (MethodWithRequires), Tool.Analyzer | Tool.NativeAot, "NativeAOT Specific Warning")]
public static void Test ()
{
MethodWithRequires ();
Expand Down
2 changes: 1 addition & 1 deletion src/tools/illink/test/Mono.Linker.Tests.Cases/DataFlow/ExponentialDataFlow.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ class GenericTypeWithRequires<
{
}

[ExpectedWarning ("IL3050", Tool.Analyzer | Tool.NativeAot, "")]
[ExpectedWarning ("IL3050", Tool.Analyzer | Tool.NativeAot, "NativeAOT Specific Warning")]
// The way we track arrays causes the analyzer to track exponentially many
// ArrayValues in the ValueSet for the pattern in this method, hitting the limit.
// When this happens, we replace the ValueSet with an unknown value, producing
Expand Down
Loading