Skip to content

Add a regression test for double Content-Length header in HttpWebRequest #102989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 6, 2024
Merged

Add a regression test for double Content-Length header in HttpWebRequest #102989

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions src/libraries/System.Net.Requests/tests/HttpWebRequestTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2120,9 +2120,11 @@ await server.AcceptConnectionAsync(_ =>
}

[Theory]
[InlineData(true)]
[InlineData(false)]
public async Task SendHttpPostRequest_WhenBufferingChanges_Success(bool buffering)
[InlineData(true, true)]
[InlineData(true, false)]
[InlineData(false, true)]
[InlineData(false, false)]
public async Task SendHttpPostRequest_WhenBufferingChanges_Success(bool buffering, bool setContentLength)
{
byte[] randomData = Encoding.ASCII.GetBytes("Hello World!!!!\n");
await LoopbackServer.CreateClientAndServerAsync(
Expand All @@ -2132,6 +2134,12 @@ await LoopbackServer.CreateClientAndServerAsync(
HttpWebRequest request = WebRequest.CreateHttp(uri);
request.Method = "POST";
request.AllowWriteStreamBuffering = buffering;

if (setContentLength)
{
request.Headers.Add("content-length", size.ToString());
}

using var stream = await request.GetRequestStreamAsync();
for (int i = 0; i < size / randomData.Length; i++)
{
Expand Down